KTOR-8901 Remove @KtorDsl from functions

Author: osipxd

ktor-client/ktor-client-core/common/src/io/ktor/client/HttpClient.kt

@@ -329,7 +329,6 @@ import kotlin.coroutines.CoroutineContext
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.client.HttpClient)
  */
-@KtorDsl
 public expect fun HttpClient(
     block: HttpClientConfig<*>.() -> Unit = {}
 ): HttpClient
@@ -642,7 +641,6 @@ public expect fun HttpClient(
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.client.HttpClient)
  */
-@KtorDsl
 public fun <T : HttpClientEngineConfig> HttpClient(
     engineFactory: HttpClientEngineFactory<T>,
     block: HttpClientConfig<T>.() -> Unit = {}
@@ -968,7 +966,6 @@ public fun <T : HttpClientEngineConfig> HttpClient(
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.client.HttpClient)
  */
-@KtorDsl
 public fun HttpClient(
     engine: HttpClientEngine,
     block: HttpClientConfig<*>.() -> Unit

ktor-client/ktor-client-core/jsAndWasmShared/src/io/ktor/client/HttpClientJs.kt

@@ -16,7 +16,6 @@ import io.ktor.utils.io.*
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.client.HttpClient)
  */
-@KtorDsl
 public actual fun HttpClient(
     block: HttpClientConfig<*>.() -> Unit
 ): HttpClient = HttpClient(FACTORY, block)

ktor-client/ktor-client-core/jvm/src/io/ktor/client/HttpClientJvm.kt

@@ -20,7 +20,6 @@ import java.util.*
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.client.HttpClient)
  */
-@KtorDsl
 public actual fun HttpClient(
     block: HttpClientConfig<*>.() -> Unit
 ): HttpClient = HttpClient(FACTORY, block)

ktor-client/ktor-client-core/posix/src/io/ktor/client/HttpClient.kt

@@ -15,7 +15,6 @@ import io.ktor.utils.io.*
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.client.HttpClient)
  */
-@KtorDsl
 public actual fun HttpClient(
     block: HttpClientConfig<*>.() -> Unit
 ): HttpClient = HttpClient(FACTORY, block)

ktor-client/ktor-client-plugins/ktor-client-auth/common/src/io/ktor/client/plugins/auth/providers/BasicAuthProvider.kt

@@ -19,7 +19,6 @@ import io.ktor.utils.io.core.*
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.client.plugins.auth.providers.basic)
  */
-@KtorDsl
 public fun AuthConfig.basic(block: BasicAuthConfig.() -> Unit) {
     with(BasicAuthConfig().apply(block)) {
         this@basic.providers.add(BasicAuthProvider(credentials, realm, _sendWithoutRequest))

ktor-client/ktor-client-webrtc/common/src/io/ktor/client/webrtc/WebRtcClient.kt

@@ -45,7 +45,6 @@ public fun interface WebRtcClientEngineFactory<out T : WebRtcConfig> {
  * ```
  * @param block configuration block for the client
  */
-@KtorDsl
 @ExperimentalKtorApi
 public fun <T : WebRtcConfig> WebRtcClient(
     factory: WebRtcClientEngineFactory<T>,

ktor-io/common/src/io/ktor/utils/io/Annotations.kt

@@ -108,5 +108,6 @@ public annotation class PublicAPICandidate(val version: String)
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.utils.io.KtorDsl)
  */
 @DslMarker
+// TODO KTOR-8901: Remove AnnotationTarget.FUNCTION
 @Target(AnnotationTarget.CLASS, AnnotationTarget.TYPEALIAS, AnnotationTarget.TYPE, AnnotationTarget.FUNCTION)
 public annotation class KtorDsl

ktor-server/ktor-server-core/common/src/io/ktor/server/application/Application.kt

@@ -21,6 +21,9 @@ import kotlin.coroutines.EmptyCoroutineContext
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.application.ServerConfigBuilder)
  */
+@Suppress("ktlint:standard:no-consecutive-comments")
+// TODO KTOR-8809: Uncomment the annotation
+// @KtorDsl
 public class ServerConfigBuilder(
     public val environment: ApplicationEnvironment
 ) {

ktor-server/ktor-server-core/common/src/io/ktor/server/engine/ApplicationEngine.kt

@@ -6,7 +6,8 @@ package io.ktor.server.engine
 
 import io.ktor.server.application.*
 import io.ktor.server.engine.internal.*
-import kotlinx.coroutines.*
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.withContext
 
 /**
  * An engine which runs an application.
@@ -20,7 +21,9 @@ public interface ApplicationEngine {
      *
      * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.engine.ApplicationEngine.Configuration)
      */
-    @Suppress("MemberVisibilityCanBePrivate")
+    @Suppress("MemberVisibilityCanBePrivate", "ktlint:standard:no-consecutive-comments")
+    // TODO KTOR-8809: Uncomment the annotation
+    // @KtorDsl
     public open class Configuration {
         /**
          * Returns the current parallelism level (e.g. the number of available processors).

ktor-server/ktor-server-core/common/src/io/ktor/server/routing/RegexRouting.kt

@@ -8,8 +8,7 @@ import io.ktor.http.*
 import io.ktor.server.application.*
 import io.ktor.server.request.*
 import io.ktor.util.*
-import io.ktor.utils.io.*
-import kotlin.jvm.*
+import kotlin.jvm.JvmName
 
 /**
  * Builds a route to match the specified regex [path].
@@ -27,7 +26,6 @@ import kotlin.jvm.*
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.route)
  */
-@KtorDsl
 public fun Route.route(path: Regex, build: Route.() -> Unit): Route =
     createRouteFromRegexPath(path).apply(build)
 
@@ -47,7 +45,6 @@ public fun Route.route(path: Regex, build: Route.() -> Unit): Route =
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.route)
  */
-@KtorDsl
 public fun Route.route(path: Regex, method: HttpMethod, build: Route.() -> Unit): Route {
     val selector = HttpMethodRouteSelector(method)
     return createRouteFromRegexPath(path).createChild(selector).apply(build)
@@ -67,7 +64,6 @@ public fun Route.route(path: Regex, method: HttpMethod, build: Route.() -> Unit)
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.get)
  */
-@KtorDsl
 public fun Route.get(path: Regex, body: RoutingHandler): Route {
     return route(path, HttpMethod.Get) { handle(body) }
 }
@@ -86,7 +82,6 @@ public fun Route.get(path: Regex, body: RoutingHandler): Route {
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.post)
  */
-@KtorDsl
 public fun Route.post(path: Regex, body: RoutingHandler): Route {
     return route(path, HttpMethod.Post) { handle(body) }
 }
@@ -105,7 +100,6 @@ public fun Route.post(path: Regex, body: RoutingHandler): Route {
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.post)
  */
-@KtorDsl
 @JvmName("postTypedPath")
 public inline fun <reified R : Any> Route.post(
     path: Regex,
@@ -128,7 +122,6 @@ public inline fun <reified R : Any> Route.post(
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.head)
  */
-@KtorDsl
 public fun Route.head(path: Regex, body: RoutingHandler): Route {
     return route(path, HttpMethod.Head) { handle(body) }
 }
@@ -147,7 +140,6 @@ public fun Route.head(path: Regex, body: RoutingHandler): Route {
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.put)
  */
-@KtorDsl
 public fun Route.put(path: Regex, body: RoutingHandler): Route {
     return route(path, HttpMethod.Put) { handle(body) }
 }
@@ -166,7 +158,6 @@ public fun Route.put(path: Regex, body: RoutingHandler): Route {
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.put)
  */
-@KtorDsl
 @JvmName("putTypedPath")
 public inline fun <reified R : Any> Route.put(
     path: Regex,
@@ -189,7 +180,6 @@ public inline fun <reified R : Any> Route.put(
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.patch)
  */
-@KtorDsl
 public fun Route.patch(path: Regex, body: RoutingHandler): Route {
     return route(path, HttpMethod.Patch) { handle(body) }
 }
@@ -208,7 +198,6 @@ public fun Route.patch(path: Regex, body: RoutingHandler): Route {
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.patch)
  */
-@KtorDsl
 @JvmName("patchTypedPath")
 public inline fun <reified R : Any> Route.patch(
     path: Regex,
@@ -231,7 +220,6 @@ public inline fun <reified R : Any> Route.patch(
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.delete)
  */
-@KtorDsl
 public fun Route.delete(path: Regex, body: RoutingHandler): Route {
     return route(path, HttpMethod.Delete) { handle(body) }
 }
@@ -250,7 +238,6 @@ public fun Route.delete(path: Regex, body: RoutingHandler): Route {
  *
  * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.routing.options)
  */
-@KtorDsl
 public fun Route.options(path: Regex, body: RoutingHandler): Route {
     return route(path, HttpMethod.Options) { handle(body) }
 }