-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Description
Summary
Trying to contribute as a Windows developer to this repo turned up several significant issues:
-
Several folders (e.g.,
kubernetes/config
,kubernetes/watch
) are symlinks tobase/
subdirectories in the repo. On Windows and when using ZIP downloads from GitHub, these appear as plain text files and break bothpip install -e .
and running tests, since setuptools expects actual directories. -
At least one test file (
watch_test.py
underkubernetes/base/watch
and duplicated underkubernetes/watch
) is missingimport json
. This causes test failures withNameError: name 'json' is not defined
. -
Several tests (for example,
test_oidc_with_refresh
insidekube_config_test.py
) fail on Windows withPermissionError
when trying to create/write temp files.
Steps to Reproduce
- Clone or download the repo on Windows.
- Try
pip install -e .
or runpython -m pytest
. - Observe errors related to config/watch packages not being directories, import errors in test files, and permission errors for temp files.
Proposed Fixes
- Replace symlinks (
kubernetes/config
,kubernetes/watch
, etc.) with real directories or use another structure to support Windows and ZIP-based contributors. - Ensure all test modules have necessary imports (e.g.,
import json
). - Refactor or skip the failing temp file tests on Windows, or improve documentation about required permissions.
Environment
- OS: Windows 10/11, Python 3.13
- (Include
pip list
orpip freeze
if desired)
Thank you! I’m happy to give more details or to help test solutions.