Skip to content

Commit 0db85fd

Browse files
authored
Merge pull request #410 from mauriciopoppe/presubmit-bios-error-library-development
Replace wmic with PowerShell's Get-CimInstance cmdlet
2 parents 604def9 + cebbc2a commit 0db85fd

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

integrationtests/system_test.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
"os/exec"
87
"strings"
98
"testing"
109

@@ -25,13 +24,13 @@ func TestSystem(t *testing.T) {
2524
require.Nil(t, err)
2625
require.NotNil(t, response)
2726

28-
result, err := exec.Command("wmic", "bios", "get", "serialnumber").Output()
29-
require.Nil(t, err)
30-
31-
t.Logf("The serial number is %s", response.SerialNumber)
27+
serialNumber, err := runPowershellCmd(t, fmt.Sprintf(`(Get-CimInstance -ClassName Win32_BIOS).SerialNumber`))
28+
if err != nil {
29+
t.Fatalf("command to get serial number failed: %v", err)
30+
}
31+
t.Logf("The serial number is %s", serialNumber)
3232

33-
resultString := string(result)
34-
require.True(t, strings.Contains(resultString, response.SerialNumber))
33+
require.True(t, strings.Contains(serialNumber, response.SerialNumber))
3534
})
3635

3736
t.Run("GetService", func(t *testing.T) {
@@ -54,7 +53,7 @@ func TestSystem(t *testing.T) {
5453
ServiceName))
5554
require.NoError(t, err)
5655

57-
var serviceInfo = struct {
56+
serviceInfo := struct {
5857
DisplayName string `json:"DisplayName"`
5958
Status uint32 `json:"Status"`
6059
StartType uint32 `json:"StartType"`

0 commit comments

Comments
 (0)