Skip to content

fix TestListVolume failure #2856

@andyzhangx

Description

@andyzhangx

Is your feature request related to a problem?/Why is this needed

when 140108d is reverted, there is TestListVolume failure related to mock interface issue.

--- FAIL: TestCommonAttachDisk (0.20s)
    --- FAIL: TestCommonAttachDisk/LUN_-1_and_error_shall_be_returned_if_there's_no_such_instance_corresponding_to_given_nodeName (0.10s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xa0 pc=0x26f2c37]

goroutine 50 [running]:
testing.tRunner.func1.2({0x2bce1a0, 0x545e920})
        /root/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1632 +0x230
testing.tRunner.func1()
        /root/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1635 +0x35e
panic({0x2bce1a0?, 0x545e920?})
        /root/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:785 +0x132
sigs.k8s.io/cloud-provider-azure/pkg/provider.(*availabilitySet).GetDataDisks(0x10?, {0x3669b70?, 0x54c23e0?}, {0x321bd70?, 0xc0006036b0?}, 0x41700b?)
        /root/go/src/sigs.k8s.io/azuredisk-csi-driver/vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_controller_standard.go:261 +0x37
sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.(*controllerCommon).GetNodeDataDisks(0x471bfd?, {0x321bd70, 0x3}, 0x0)
        /root/go/src/sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk/azure_controller_common.go:453 +0x85
sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.(*controllerCommon).SetDiskLun(0xc00039e1e0?, {0x321bd70, 0x3}, {0xc0002042a0, 0x59}, 0xc000386240, {0x0, 0x0, 0x3fa25e50d84a3e0d?})
        /root/go/src/sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk/azure_controller_common.go:486 +0x5c
sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.(*controllerCommon).AttachDisk(0xc00039e1e0, {0x3669de0, 0xc0004fc780}, {0x322354a, 0x9}, {0xc000204180, 0x59}, {0x321bd70, 0x3}, {0x3221a4d, ...}, ...)
        /root/go/src/sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk/azure_controller_common.go:213 +0x10ae
sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.TestCommonAttachDisk.func3(0xc0000c0000)
        /root/go/src/sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk/azure_controller_common_test.go:255 +0x6ed
testing.tRunner(0xc0000c0000, 0xc0002cc000)
        /root/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1690 +0xf4
created by testing.(*T).Run in goroutine 43
        /root/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1743 +0x390
exit status 2

Describe the solution you'd like in detail

Describe alternatives you've considered

Additional context

Metadata

Metadata

Assignees

Labels

kind/failing-testCategorizes issue or PR as related to a consistently or frequently failing test.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions