Skip to content

Commit 7a78ca0

Browse files
committed
Bump conversion-gen to v0.34.0
1 parent f4ff5a8 commit 7a78ca0

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ GOTESTSUM_BIN := gotestsum
121121
GOTESTSUM := $(abspath $(TOOLS_BIN_DIR)/$(GOTESTSUM_BIN)-$(GOTESTSUM_VER))
122122
GOTESTSUM_PKG := gotest.tools/gotestsum
123123

124-
CONVERSION_GEN_VER := v0.33.0
124+
CONVERSION_GEN_VER := v0.34.0
125125
CONVERSION_GEN_BIN := conversion-gen
126126
# We are intentionally using the binary without version suffix, to avoid the version
127127
# in generated files.

api/core/v1beta1/conversion.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2285,8 +2285,6 @@ func convertToObjectReference(ref clusterv1.ContractVersionedObjectReference, na
22852285
}
22862286

22872287
func Convert_v1beta1_JSONSchemaProps_To_v1beta2_JSONSchemaProps(in *JSONSchemaProps, out *clusterv1.JSONSchemaProps, s apimachineryconversion.Scope) error {
2288-
// This conversion func is also required due to a bug in conversion gen that does not recognize the changes for converting bool to *bool.
2289-
// By implementing this func, autoConvert_v1beta1_JSONSchemaProps_To_v1beta2_JSONSchemaProps is generated properly.
22902288
if err := autoConvert_v1beta1_JSONSchemaProps_To_v1beta2_JSONSchemaProps(in, out, s); err != nil {
22912289
return err
22922290
}

0 commit comments

Comments
 (0)