Skip to content

Commit df9aaf7

Browse files
committed
Bump CR again & fix managedField unit tests
1 parent c2af275 commit df9aaf7

File tree

7 files changed

+25
-13
lines changed

7 files changed

+25
-13
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ require (
4949
k8s.io/klog/v2 v2.130.1
5050
k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b
5151
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397
52-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed
52+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31
5353
sigs.k8s.io/randfill v1.0.0
5454
sigs.k8s.io/yaml v1.6.0
5555
)

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -606,8 +606,8 @@ rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
606606
rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
607607
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 h1:jpcvIRr3GLoUoEKRkHKSmGjxb6lWwrBlJsXc+eUYQHM=
608608
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2/go.mod h1:Ve9uj1L+deCXFrPOk1LpFXqTg7LCFzFso6PA48q/XZw=
609-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed h1:NrsJjgJDRmiYeuqRF4qCXnPKJQmXqLllMOpyVi0iFsI=
610-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed/go.mod h1:LjUyR9UOOF+gtX64YtT4D5tYdcrmQv1wS7L+SRE4T5g=
609+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31 h1:ttWlwypzv2HeC4G5sMVKFTd7K45qlstdDefL04aMFkU=
610+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31/go.mod h1:LjUyR9UOOF+gtX64YtT4D5tYdcrmQv1wS7L+SRE4T5g=
611611
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=
612612
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8/go.mod h1:mdzfpAEoE6DHQEN0uh9ZbOCuHbLK5wOm7dK4ctXE9Tg=
613613
sigs.k8s.io/randfill v1.0.0 h1:JfjMILfT8A6RbawdsK2JXGBR5AQVfd+9TbzrlneTyrU=

hack/tools/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ require (
2626
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397
2727
sigs.k8s.io/cluster-api v0.0.0-00010101000000-000000000000
2828
sigs.k8s.io/cluster-api/test v0.0.0-00010101000000-000000000000
29-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed
29+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31
3030
sigs.k8s.io/controller-tools v0.18.0
3131
sigs.k8s.io/kubebuilder/docs/book/utils v0.0.0-20211028165026-57688c578b5d
3232
sigs.k8s.io/kustomize/api v0.17.3

hack/tools/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,8 @@ k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 h1:hwvWFiBzdWw1FhfY1FooPn3kzWuJ8
542542
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
543543
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 h1:jpcvIRr3GLoUoEKRkHKSmGjxb6lWwrBlJsXc+eUYQHM=
544544
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2/go.mod h1:Ve9uj1L+deCXFrPOk1LpFXqTg7LCFzFso6PA48q/XZw=
545-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed h1:NrsJjgJDRmiYeuqRF4qCXnPKJQmXqLllMOpyVi0iFsI=
546-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed/go.mod h1:LjUyR9UOOF+gtX64YtT4D5tYdcrmQv1wS7L+SRE4T5g=
545+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31 h1:ttWlwypzv2HeC4G5sMVKFTd7K45qlstdDefL04aMFkU=
546+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31/go.mod h1:LjUyR9UOOF+gtX64YtT4D5tYdcrmQv1wS7L+SRE4T5g=
547547
sigs.k8s.io/controller-tools v0.18.0 h1:rGxGZCZTV2wJreeRgqVoWab/mfcumTMmSwKzoM9xrsE=
548548
sigs.k8s.io/controller-tools v0.18.0/go.mod h1:gLKoiGBriyNh+x1rWtUQnakUYEujErjXs9pf+x/8n1U=
549549
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=

internal/util/ssa/managedfields_test.go

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ func TestDropManagedFieldsWithFakeClient(t *testing.T) {
162162
Operation: metav1.ManagedFieldsOperationUpdate,
163163
FieldsType: "FieldsV1",
164164
FieldsV1: &metav1.FieldsV1{Raw: fieldV1},
165+
APIVersion: "v1",
165166
}},
166167
Labels: map[string]string{
167168
"label-1": "value-1",
@@ -186,10 +187,13 @@ func TestDropManagedFieldsWithFakeClient(t *testing.T) {
186187
Operation: metav1.ManagedFieldsOperationUpdate,
187188
FieldsType: "FieldsV1",
188189
FieldsV1: &metav1.FieldsV1{Raw: fieldV1},
190+
APIVersion: "v1",
189191
},
190192
{
191-
Manager: ssaManager,
192-
Operation: metav1.ManagedFieldsOperationApply,
193+
Manager: ssaManager,
194+
Operation: metav1.ManagedFieldsOperationApply,
195+
FieldsType: "FieldsV1",
196+
APIVersion: "v1",
193197
},
194198
},
195199
Labels: map[string]string{
@@ -225,7 +229,7 @@ func TestDropManagedFieldsWithFakeClient(t *testing.T) {
225229
for _, tt := range tests {
226230
t.Run(tt.name, func(t *testing.T) {
227231
g := NewWithT(t)
228-
fakeClient := fake.NewClientBuilder().WithObjects(tt.obj).Build()
232+
fakeClient := fake.NewClientBuilder().WithObjects(tt.obj).WithReturnManagedFields().Build()
229233
labelsAndAnnotationsManagedFieldPaths := []contract.Path{
230234
{"f:metadata", "f:annotations"},
231235
{"f:metadata", "f:labels"},
@@ -416,6 +420,8 @@ func TestCleanUpManagedFieldsForSSAAdoptionWithFakeClient(t *testing.T) {
416420
ManagedFields: []metav1.ManagedFieldsEntry{{
417421
Manager: classicManager,
418422
Operation: metav1.ManagedFieldsOperationUpdate,
423+
FieldsType: "FieldsV1",
424+
APIVersion: "v1",
419425
}},
420426
},
421427
Data: map[string]string{
@@ -429,6 +435,8 @@ func TestCleanUpManagedFieldsForSSAAdoptionWithFakeClient(t *testing.T) {
429435
ManagedFields: []metav1.ManagedFieldsEntry{{
430436
Manager: ssaManager,
431437
Operation: metav1.ManagedFieldsOperationApply,
438+
FieldsType: "FieldsV1",
439+
APIVersion: "v1",
432440
}},
433441
},
434442
Data: map[string]string{
@@ -443,10 +451,14 @@ func TestCleanUpManagedFieldsForSSAAdoptionWithFakeClient(t *testing.T) {
443451
{
444452
Manager: classicManager,
445453
Operation: metav1.ManagedFieldsOperationUpdate,
454+
FieldsType: "FieldsV1",
455+
APIVersion: "v1",
446456
},
447457
{
448458
Manager: ssaManager,
449459
Operation: metav1.ManagedFieldsOperationApply,
460+
FieldsType: "FieldsV1",
461+
APIVersion: "v1",
450462
},
451463
},
452464
},
@@ -485,7 +497,7 @@ func TestCleanUpManagedFieldsForSSAAdoptionWithFakeClient(t *testing.T) {
485497
for _, tt := range tests {
486498
t.Run(tt.name, func(t *testing.T) {
487499
g := NewWithT(t)
488-
fakeClient := fake.NewClientBuilder().WithObjects(tt.obj).Build()
500+
fakeClient := fake.NewClientBuilder().WithObjects(tt.obj).WithReturnManagedFields().Build()
489501
g.Expect(CleanUpManagedFieldsForSSAAdoption(ctx, fakeClient, tt.obj, ssaManager)).Should(Succeed())
490502
g.Expect(tt.obj.GetManagedFields()).Should(
491503
ContainElement(MatchManagedFieldsEntry(ssaManager, metav1.ManagedFieldsOperationApply)))

test/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ require (
3333
k8s.io/klog/v2 v2.130.1
3434
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397
3535
sigs.k8s.io/cluster-api v0.0.0-00010101000000-000000000000
36-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed
36+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31
3737
sigs.k8s.io/kind v0.29.0
3838
sigs.k8s.io/randfill v1.0.0
3939
sigs.k8s.io/yaml v1.6.0

test/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,8 +474,8 @@ k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 h1:hwvWFiBzdWw1FhfY1FooPn3kzWuJ8
474474
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
475475
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 h1:jpcvIRr3GLoUoEKRkHKSmGjxb6lWwrBlJsXc+eUYQHM=
476476
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2/go.mod h1:Ve9uj1L+deCXFrPOk1LpFXqTg7LCFzFso6PA48q/XZw=
477-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed h1:NrsJjgJDRmiYeuqRF4qCXnPKJQmXqLllMOpyVi0iFsI=
478-
sigs.k8s.io/controller-runtime v0.21.1-0.20250813191507-c7df6d0236ed/go.mod h1:LjUyR9UOOF+gtX64YtT4D5tYdcrmQv1wS7L+SRE4T5g=
477+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31 h1:ttWlwypzv2HeC4G5sMVKFTd7K45qlstdDefL04aMFkU=
478+
sigs.k8s.io/controller-runtime v0.21.1-0.20250818110513-3554729cfb31/go.mod h1:LjUyR9UOOF+gtX64YtT4D5tYdcrmQv1wS7L+SRE4T5g=
479479
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=
480480
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8/go.mod h1:mdzfpAEoE6DHQEN0uh9ZbOCuHbLK5wOm7dK4ctXE9Tg=
481481
sigs.k8s.io/kind v0.29.0 h1:3TpCsyh908IkXXpcSnsMjWdwdWjIl7o9IMZImZCWFnI=

0 commit comments

Comments
 (0)