cleanup modelName from inferenceObjective. (#1521)

Author: zetxqx

apix/v1alpha2/inferenceobjective_types.go

@@ -25,7 +25,6 @@ import (
 // +kubebuilder:object:root=true
 // +kubebuilder:subresource:status
 // +kubebuilder:storageversion
-// +kubebuilder:printcolumn:name="Model Name",type=string,JSONPath=`.spec.modelName`
 // +kubebuilder:printcolumn:name="Inference Pool",type=string,JSONPath=`.spec.poolRef.name`
 // +kubebuilder:printcolumn:name="Priority",type=string,JSONPath=`.spec.priority`
 // +kubebuilder:printcolumn:name="Age",type=date,JSONPath=`.metadata.creationTimestamp`
@@ -56,12 +55,6 @@ type InferenceObjectiveList struct {
 // performance and latency goals for the model. These workloads are
 // expected to operate within an InferencePool sharing compute capacity with other
 // InferenceObjectives, defined by the Inference Platform Admin.
-//
-// InferenceObjective's modelName (not the ObjectMeta name) is unique for a given InferencePool,
-// if the name is reused, an error will be shown on the status of a
-// InferenceObjective that attempted to reuse. The oldest InferenceObjective, based on
-// creation timestamp, will be selected to remain valid. In the event of a race
-// condition, one will be selected at random.
 type InferenceObjectiveSpec struct {
 
 	// Priority defines how important it is to serve the request compared to other requests in the same pool.
@@ -135,10 +128,6 @@ const (
 	//
 	// * "Accepted"
 	//
-	// Possible reasons for this condition to be False are:
-	//
-	// * "ModelNameInUse"
-	//
 	// Possible reasons for this condition to be Unknown are:
 	//
 	// * "Pending"
@@ -148,10 +137,6 @@ const (
 	// ObjectiveReasonAccepted is the desired state. Model conforms to the state of the pool.
 	ObjectiveReasonAccepted InferenceObjectiveConditionReason = "Accepted"
 
-	// ObjectiveReasonNameInUse is used when a given ModelName already exists within the pool.
-	// Details about naming conflict resolution are on the ModelName field itself.
-	ObjectiveReasonNameInUse InferenceObjectiveConditionReason = "ModelNameInUse"
-
 	// ObjectiveReasonPending is the initial state, and indicates that the controller has not yet reconciled the InferenceObjective.
 	ObjectiveReasonPending InferenceObjectiveConditionReason = "Pending"
 )

config/crd/bases/inference.networking.x-k8s.io_inferenceobjectives.yaml

@@ -15,9 +15,6 @@ spec:
   scope: Namespaced
   versions:
   - additionalPrinterColumns:
-    - jsonPath: .spec.modelName
-      name: Model Name
-      type: string
     - jsonPath: .spec.poolRef.name
       name: Inference Pool
       type: string
@@ -61,12 +58,6 @@ spec:
               performance and latency goals for the model. These workloads are
               expected to operate within an InferencePool sharing compute capacity with other
               InferenceObjectives, defined by the Inference Platform Admin.
-
-              InferenceObjective's modelName (not the ObjectMeta name) is unique for a given InferencePool,
-              if the name is reused, an error will be shown on the status of a
-              InferenceObjective that attempted to reuse. The oldest InferenceObjective, based on
-              creation timestamp, will be selected to remain valid. In the event of a race
-              condition, one will be selected at random.
             properties:
               poolRef:
                 description: PoolRef is a reference to the inference pool, the pool