Skip to content

chore: added proper inference-extension- prefix for demostration manifests #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: added proper inference-extension- prefix for demostration manifests #1194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d56f9
chore: added proper `inference-extension-` prefix for demostration ma…
nekomeowww Jul 21, 2025
2ddad9c
chore: rename
nekomeowww Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions config/manifests/inferencepool-resources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ apiVersion: inference.networking.x-k8s.io/v1alpha2
kind: InferencePool
metadata:
name: vllm-llama3-8b-instruct
namespace: default
spec:
targetPortNumber: 8000
selector:
Expand Down Expand Up @@ -90,12 +91,12 @@ spec:
volumes:
- name: plugins-config-volume
configMap:
name: plugins-config
name: inference-gateway-plugins-config
---
apiVersion: v1
kind: ConfigMap
metadata:
name: plugins-config
name: inference-gateway-plugins-config
namespace: default
data:
default-plugins.yaml: |
Expand Down Expand Up @@ -177,7 +178,8 @@ data:
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: pod-read
name: inference-gateway-read-clusterrole
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we remove the namespace definitions in this file so a user can set a different namespace manually using kubectl apply.

rules:
- apiGroups: ["inference.networking.x-k8s.io"]
resources: ["inferencepools"]
Expand All @@ -200,16 +202,16 @@ rules:
- subjectaccessreviews
verbs:
- create
---
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: pod-read-binding
name: inference-gateway-read-clusterrole-binding
subjects:
- kind: ServiceAccount
name: default
name: inference-gateway-default
namespace: default
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: pod-read
name: inference-gateway-read-clusterrole