validate tags early during volume creation

Author: RomanBednar

pkg/csi_driver/controller.go

@@ -285,6 +285,14 @@ func (s *controllerServer) CreateVolume(ctx context.Context, req *csi.CreateVolu
 		return nil, file.StatusError(err)
 	}
 
+	// If tags are used, check if they exist
+	if tags, ok := req.GetParameters()[cloud.ParameterKeyResourceTags]; ok {
+		_, err = s.config.tagManager.ValidateResourceTags(ctx, "CreateVolumeRequest", tags)
+		if err != nil {
+			return nil, status.Error(codes.InvalidArgument, err.Error())
+		}
+	}
+
 	if filer != nil {
 		klog.V(4).Infof("Found existing instance %+v, current instance %+v\n", filer, newFiler)
 		// Instance already exists, check if it meets the request

pkg/csi_driver/controller_test.go

@@ -782,6 +782,13 @@ func TestCreateVolume(t *testing.T) {
 	for _, test := range cases {
 		cs := initTestController(t).(*controllerServer)
 		cs.config.features = test.features
+
+		if tags, ok := test.req.GetParameters()[cloud.ParameterKeyResourceTags]; ok {
+			cs.config.tagManager.(*cloud.FakeTagServiceManager).
+				On("ValidateResourceTags", context.TODO(), tags).
+				Return(nil, nil)
+		}
+
 		cs.config.tagManager.(*cloud.FakeTagServiceManager).
 			On("AttachResourceTags", context.TODO(), cloud.FilestoreInstance, testCSIVolume, testLocation, test.req.GetName(), test.req.GetParameters()).
 			Return(nil)