-
Notifications
You must be signed in to change notification settings - Fork 23
Open
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Description
Hi,
I'm trying to use the cluster-api CLUSTER_TOPOLOGY feature with the karpenter cluster-api provider, but it results in an error while filtering compatible instance types by instance types.
My understanding is: this seems to come from the nodeLabelsFromMachineDeployment function, because it retrieves labels that would be used to filter from two places:
- machineDeployment.Spec.Template.Labels
- machineDeployment.annotations
But while enabling the cluster_topology feature, it seems that labels added to the MachineDeployment are automatically transposed to machineDeployment.Spec.Template.Labels, meaning that it will return labels such as the node.cluster.x-k8s.io/karpenter-member: "" one
It will raise an error in the filterCompatibleInstanceTypes function at the reqs.Compatible call for those unwanted labels
Metadata
Metadata
Assignees
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.