allow using helmChart without repo URL.

Author: aarnaud

api/internal/builtins/HelmChartInflationGenerator.go

@@ -160,7 +160,7 @@ func (p *plugin) absChartHome() string {
 		chartHome = filepath.Join(p.h.Loader().Root(), p.ChartHome)
 	}
 
-	if p.Version != "" && p.Repo != "" {
+	if p.Version != "" {
 		return filepath.Join(chartHome, fmt.Sprintf("%s-%s", p.Name, p.Version))
 	}
 	return chartHome
@@ -361,7 +361,7 @@ func (p *plugin) chartExistsLocally() (string, bool) {
 	path := filepath.Join(p.absChartHome(), p.Name)
 	s, err := os.Stat(path)
 	if err != nil {
-		return "", false
+		return path, false
 	}
 	return path, s.IsDir()
 }

plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go

@@ -847,7 +847,7 @@ releaseName: %s
 			assert.True(t, len(rm.Resources()) > 0)
 
 			var chartDir string
-			if tt.version != "" && tt.repo != "" {
+			if tt.version != "" {
 				chartDir = fmt.Sprintf("charts/%s-%s/%s", tt.chartName, tt.version, tt.chartName)
 			} else {
 				chartDir = fmt.Sprintf("charts/%s", tt.chartName)
@@ -949,7 +949,7 @@ chartHome: ./charts
 	require.NoError(t, err)
 	assert.Equal(t, "bar", cm)
 
-	chartDir := filepath.Join(th.GetRoot(), "charts/test-chart")
+	chartDir := filepath.Join(th.GetRoot(), "charts/test-chart-1.0.0/test-chart")
 	assert.True(t, th.GetFSys().Exists(chartDir))
 
 	chartYamlContent, err := th.GetFSys().ReadFile(filepath.Join(chartDir, "Chart.yaml"))
@@ -983,7 +983,7 @@ debug: true
 	require.NoError(t, err)
 	assert.Equal(t, "bar", cm)
 
-	chartDir := filepath.Join(th.GetRoot(), "charts/test-chart")
+	chartDir := filepath.Join(th.GetRoot(), "charts/test-chart-1.0.0/test-chart")
 	assert.True(t, th.GetFSys().Exists(chartDir))
 
 	chartYamlContent, err := th.GetFSys().ReadFile(filepath.Join(chartDir, "Chart.yaml"))