Skip to content

Commit 53a8527

Browse files
committed
fix/tests/nlb/lb: fix LB tests after sdk v2 updates
1 parent 87b700f commit 53a8527

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

pkg/providers/v1/aws_loadbalancer_test.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1558,9 +1558,9 @@ func TestCloud_ensureTargetGroupAttributes(t *testing.T) {
15581558
t.Run(tt.name, func(t *testing.T) {
15591559
mockClient := &mockELBV2ClientForTargetGroupAttributes{
15601560
MockedFakeELBV2: &MockedFakeELBV2{
1561-
LoadBalancers: []elbv2types.LoadBalancer{},
1562-
TargetGroups: []elbv2types.TargetGroup{},
1563-
Listeners: []elbv2types.Listener{},
1561+
LoadBalancers: []*elbv2types.LoadBalancer{},
1562+
TargetGroups: []*elbv2types.TargetGroup{},
1563+
Listeners: []*elbv2types.Listener{},
15641564
LoadBalancerAttributes: make(map[string]map[string]string),
15651565
Tags: make(map[string][]elbv2types.Tag),
15661566
RegisteredInstances: make(map[string][]string),
@@ -1593,7 +1593,7 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
15931593
name string
15941594
lbARN string
15951595
annotations map[string]string
1596-
targetGroups []elbv2types.TargetGroup
1596+
targetGroups []*elbv2types.TargetGroup
15971597
describeTargetGroupsError error
15981598
describeTargetGroupAttributesFunc func(ctx context.Context, input *elbv2.DescribeTargetGroupAttributesInput, optFns ...func(*elbv2.Options)) (*elbv2.DescribeTargetGroupAttributesOutput, error)
15991599
modifyTargetGroupAttributesFunc func(ctx context.Context, input *elbv2.ModifyTargetGroupAttributesInput, optFns ...func(*elbv2.Options)) (*elbv2.ModifyTargetGroupAttributesOutput, error)
@@ -1616,13 +1616,13 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
16161616
name: "no target groups found - success",
16171617
lbARN: testLBARN,
16181618
annotations: map[string]string{},
1619-
targetGroups: []elbv2types.TargetGroup{},
1619+
targetGroups: []*elbv2types.TargetGroup{},
16201620
},
16211621
{
16221622
name: "single target group - success",
16231623
lbARN: testLBARN,
16241624
annotations: map[string]string{ServiceAnnotationLoadBalancerTargetGroupAttributes: "preserve_client_ip.enabled=true"},
1625-
targetGroups: []elbv2types.TargetGroup{
1625+
targetGroups: []*elbv2types.TargetGroup{
16261626
{
16271627
TargetGroupArn: aws.String(testTG1ARN),
16281628
LoadBalancerArns: []string{testLBARN},
@@ -1646,7 +1646,7 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
16461646
name: "multiple target groups - success",
16471647
lbARN: testLBARN,
16481648
annotations: map[string]string{ServiceAnnotationLoadBalancerTargetGroupAttributes: "proxy_protocol_v2.enabled=true"},
1649-
targetGroups: []elbv2types.TargetGroup{
1649+
targetGroups: []*elbv2types.TargetGroup{
16501650
{
16511651
TargetGroupArn: aws.String(testTG1ARN),
16521652
LoadBalancerArns: []string{testLBARN},
@@ -1676,7 +1676,7 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
16761676
name: "partial failure - some target groups fail",
16771677
lbARN: testLBARN,
16781678
annotations: map[string]string{ServiceAnnotationLoadBalancerTargetGroupAttributes: "preserve_client_ip.enabled=true"},
1679-
targetGroups: []elbv2types.TargetGroup{
1679+
targetGroups: []*elbv2types.TargetGroup{
16801680
{
16811681
TargetGroupArn: aws.String(testTG1ARN),
16821682
LoadBalancerArns: []string{testLBARN},
@@ -1710,7 +1710,7 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
17101710
name: "all target groups fail",
17111711
lbARN: testLBARN,
17121712
annotations: map[string]string{ServiceAnnotationLoadBalancerTargetGroupAttributes: "preserve_client_ip.enabled=true"},
1713-
targetGroups: []elbv2types.TargetGroup{
1713+
targetGroups: []*elbv2types.TargetGroup{
17141714
{
17151715
TargetGroupArn: aws.String(testTG1ARN),
17161716
LoadBalancerArns: []string{testLBARN},
@@ -1733,7 +1733,7 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
17331733
name: "ModifyTargetGroupAttributes fails for some target groups",
17341734
lbARN: testLBARN,
17351735
annotations: map[string]string{ServiceAnnotationLoadBalancerTargetGroupAttributes: "preserve_client_ip.enabled=true"},
1736-
targetGroups: []elbv2types.TargetGroup{
1736+
targetGroups: []*elbv2types.TargetGroup{
17371737
{
17381738
TargetGroupArn: aws.String(testTG1ARN),
17391739
LoadBalancerArns: []string{testLBARN},
@@ -1767,7 +1767,7 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
17671767
name: "buildTargetGroupAttributes fails due to nil existing attributes",
17681768
lbARN: testLBARN,
17691769
annotations: map[string]string{ServiceAnnotationLoadBalancerTargetGroupAttributes: "preserve_client_ip.enabled=true"},
1770-
targetGroups: []elbv2types.TargetGroup{
1770+
targetGroups: []*elbv2types.TargetGroup{
17711771
{
17721772
TargetGroupArn: aws.String(testTG1ARN),
17731773
LoadBalancerArns: []string{testLBARN},
@@ -1786,7 +1786,7 @@ func TestCloud_reconcileTargetGroupsAttributes(t *testing.T) {
17861786
name: "no annotations - success",
17871787
lbARN: testLBARN,
17881788
annotations: map[string]string{}, // No target group attributes annotation
1789-
targetGroups: []elbv2types.TargetGroup{
1789+
targetGroups: []*elbv2types.TargetGroup{
17901790
{
17911791
TargetGroupArn: aws.String(testTG1ARN),
17921792
LoadBalancerArns: []string{testLBARN},

0 commit comments

Comments
 (0)