diff --git a/keps/prod-readiness/sig-node/4205.yaml b/keps/prod-readiness/sig-node/4205.yaml index fa39eafaa71..c937b461957 100644 --- a/keps/prod-readiness/sig-node/4205.yaml +++ b/keps/prod-readiness/sig-node/4205.yaml @@ -6,3 +6,5 @@ alpha: approver: "@johnbelamaric" beta: approver: "@johnbelamaric" +stable: + approver: "@johnbelamaric" diff --git a/keps/sig-node/4205-psi-metric/README.md b/keps/sig-node/4205-psi-metric/README.md index 1dc438e7a34..4d24f66918f 100644 --- a/keps/sig-node/4205-psi-metric/README.md +++ b/keps/sig-node/4205-psi-metric/README.md @@ -284,8 +284,10 @@ We expect no non-infra related flakes in the last month as a GA graduation crite - PSI metrics collection doesn't introduce excessive CPU or memory usage increase in the kubelet #### GA -- Gather evidence of real world usage. -- No major issue reported. +- Quantify the cAdvisor and kubelet-level overhead of PSI metric collection, especially where PSI is disabled at the kernel level. +- Validate with SIG Node that collection overhead is acceptable for general use cases, or include opt-out knobs. +- Gather evidence of real-world usage from beta users. +- No major issues reported. #### Deprecation @@ -375,7 +377,7 @@ feature. NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`. --> -Yes +Yes, but starting in v1.35 where this feature graduates to GA, the KubeletPSI feature gate will be locked to true and will no longer be disable-able. ###### What happens if we reenable the feature if it was previously rolled back? No PSI metrics will be available in kubelet Summary API nor Prometheus metrics if the diff --git a/keps/sig-node/4205-psi-metric/kep.yaml b/keps/sig-node/4205-psi-metric/kep.yaml index 0d2a18aa004..46ad4e0e40b 100644 --- a/keps/sig-node/4205-psi-metric/kep.yaml +++ b/keps/sig-node/4205-psi-metric/kep.yaml @@ -22,17 +22,18 @@ see-also: [] replaces: [] # The target maturity stage in the current dev cycle for this KEP. -stage: beta +stage: stable # The most recent milestone for which work toward delivery of this KEP has been # done. This can be the current (upcoming) milestone, if it is being actively # worked on. -latest-milestone: "v1.34" +latest-milestone: "v1.35" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: alpha: "v1.33" beta: "v1.34" + stable: "v1.36" # The following PRR answers are required at alpha release # List the feature gate name and the components for which it must be enabled @@ -41,7 +42,7 @@ feature-gates: components: - kubelet -disable-supported: true +disable-supported: false # The following PRR answers are required at beta release metrics: