Skip to content

Commit 48770b6

Browse files
committed
test: Fix vmnet-helper installation in the CI
The step was using wrong command that used to work with the older install script from v0.6.0. Update to use the curent install script arguemnts. The installtion fails with: Installation requires your password to install vmnet-helper as root bash: line 39: /dev/tty: Device not configured
1 parent fdbff10 commit 48770b6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/functional_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ jobs:
377377
if: matrix.os == 'macos-13' && matrix.driver == 'vfkit'
378378
run: |
379379
brew install vfkit
380-
curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash -s
380+
curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | sudo VMNET_INTERACTIVE=0 bash
381381
- name: Download Test Binaries
382382
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0
383383
with:

.github/workflows/smoke-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
if: matrix.driver == 'vfkit'
113113
run: |
114114
brew install vfkit
115-
curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash -s
115+
curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | sudo VMNET_INTERACTIVE=0 bash
116116
- name: Install qemu and socket_vmnet (macos)
117117
if: matrix.os == 'macos-13' && matrix.driver == 'qemu'
118118
run: |

0 commit comments

Comments
 (0)