Skip to content

fix spinner (after replaced fork to upstream)Β #21148

@medyagh

Description

@medyagh

since this PR #21115 that we removed the fork to use upstream

"
the Sub Steps that shows kubernetes Creating Shows for 1 miliseconds and vanishes
"
here how it looks like

$ mk start -d krunkit
πŸ˜„  minikube v1.36.0 on Darwin 15.5 (arm64)
✨  Using the krunkit (experimental) driver based on user configuration
πŸ‘  Starting "minikube" primary control-plane node in "minikube" cluster
πŸ”—  Configuring bridge CNI (Container Networking Interface) ...
πŸ”Ž  Verifying Kubernetes components...
    β–ͺ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: default-storageclass, storage-provisioner
πŸ„  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

but it is missing to big blocks
πŸ”₯ Creating
and
🐳 Preparing

here is output not from HEAD but from released minikiube

πŸ˜„  minikube v1.36.0 on Darwin 15.5 (arm64)
✨  Automatically selected the vfkit driver
πŸ‘  Starting "minikube" primary control-plane node in "minikube" cluster
πŸ”₯  Creating vfkit VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
❗  Image was not built for the current minikube version. To resolve this you can delete and recreate your minikube cluster using the latest images. Expected minikube version: v1.35.0 -> Actual minikube version: v1.36.0
🐳  Preparing Kubernetes v1.33.1 on Docker 28.0.4 ...
    β–ͺ Generating certificates and keys ...
    β–ͺ Booting up control plane ...
    β–ͺ Configuring RBAC rules ...
πŸ”—  Configuring bridge CNI (Container Networking Interface) ...
πŸ”Ž  Verifying Kubernetes components...
    β–ͺ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: default-storageclass, storage-provisioner
πŸ„  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default```

the qeustion is what is difference of "πŸ”₯ Creating" and "🐳 Preparing Kubernetes" blocks that if we use the fork (https://github.com/alonyb/spinner) it works fine but if we use upsteam https://github.com/briandowns/spinner
it doesnt work work

if we cant make it work we should Keep the old fork maybe Fork it again and bump the go mod dependecies to make it a bit more fresh https://github.com/alonyb/spinner

if @alonyb is still here can also comment :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions