Skip to content

Conversation

@divysinghvi
Copy link
Contributor

@divysinghvi divysinghvi commented Nov 23, 2025

Added integration-prow-docker-containerd-linux-x86-64 prow test
issue : #21916

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divysinghvi
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @divysinghvi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2025
@ComradeProgrammer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@minikube-pr-bot

This comment has been minimized.

@divysinghvi
Copy link
Contributor Author

/retest

@minikube-pr-bot

This comment has been minimized.

@divysinghvi
Copy link
Contributor Author

/retest

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@divysinghvi
Copy link
Contributor Author

/retest

@divysinghvi divysinghvi force-pushed the integration-dcoker-containerd branch from 0a13bf6 to f30d0b9 Compare November 24, 2025 03:55
@divysinghvi
Copy link
Contributor Author

/retest

@minikube-pr-bot

This comment has been minimized.

@divysinghvi divysinghvi force-pushed the integration-dcoker-containerd branch from e919643 to 5bc9857 Compare November 24, 2025 04:59
@divysinghvi divysinghvi changed the title WIP: Adding integration-prow-docker-containerd-linux-x86-64 prow test Added integration-prow-docker-containerd-linux-x86-64 prow test Nov 24, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@minikube-pr-bot

This comment has been minimized.

@divysinghvi divysinghvi force-pushed the integration-dcoker-containerd branch from 5bc9857 to 7124b09 Compare November 24, 2025 06:04
@minikube-pr-bot

This comment has been minimized.

@divysinghvi divysinghvi force-pushed the integration-dcoker-containerd branch from 87384e0 to af90cc9 Compare November 26, 2025 04:50
@divysinghvi
Copy link
Contributor Author

/reset

@divysinghvi divysinghvi force-pushed the integration-dcoker-containerd branch from af90cc9 to f341d89 Compare November 26, 2025 05:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2025
@minikube-pr-bot

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@divysinghvi divysinghvi force-pushed the integration-dcoker-containerd branch from 53645b2 to 055c5fe Compare November 26, 2025 07:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

}

// setContainerdUlimit sets LimitNOFILE for containerd to match docker's default ulimit
func setContainerdUlimit(cr CommandRunner) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are adding this to the kicbase this code wont be needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we won't need if we are updating the kicbase image i did not knew how the kickbase image update worked


# Set ulimit for containerd to match docker's default-ulimit setting
# This ensures consistent file descriptor limits (1048576) across container runtimes
RUN sed -i '/^\[Service\]/a LimitNOFILE=1048576' /lib/systemd/system/containerd.service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want this change plz ask one of the maintainers to run
ok-to-build-image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run ok-to-build-image sorry i am still confused about the process

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member

medyagh commented Nov 26, 2025

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @divysinghvi, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment has been minimized.

@k8s-ci-robot
Copy link
Contributor

@divysinghvi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-kvm-containerd-linux-x86-64 4cf3e56 link true /test integration-kvm-containerd-linux-x86-64
integration-docker-crio-linux-x86-64 4cf3e56 link true /test integration-docker-crio-linux-x86-64
integration-kvm-crio-linux-x86-64 4cf3e56 link true /test integration-kvm-crio-linux-x86-64
integration-kvm-docker-linux-x86-64 4cf3e56 link true /test integration-kvm-docker-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21974 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 41.0s    │ 39.5s                  │
│ enable ingress │ 15.3s    │ 15.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 39.2s 40.9s 40.1s 40.4s 44.5s
Times for minikube (PR 21974) start: 39.5s 39.8s 39.3s 39.7s 39.0s

Times for minikube ingress: 15.8s 15.7s 15.2s 14.7s 15.2s
Times for minikube (PR 21974) ingress: 15.7s 15.7s 15.8s 15.7s 15.8s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21974 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.3s    │ 21.8s                  │
│ enable ingress │ 11.0s    │ 10.6s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 22.8s 22.0s 21.1s 24.2s 21.5s
Times for minikube (PR 21974) start: 19.9s 24.5s 23.2s 20.9s 20.3s

Times for minikube ingress: 12.6s 10.6s 10.6s 10.6s 10.6s
Times for minikube (PR 21974) ingress: 10.6s 10.6s 10.6s 10.6s 10.6s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21974 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.7s    │ 19.8s                  │
│ enable ingress │ 20.3s    │ 20.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 22.0s 21.7s 21.6s 22.7s 20.4s
Times for minikube (PR 21974) start: 19.4s 18.2s 19.2s 20.5s 21.8s

Times for minikube ingress: 20.1s 21.1s 20.1s 20.1s 20.1s
Times for minikube (PR 21974) ingress: 20.1s 21.1s 20.1s 21.1s 20.1s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Windows (2 failed) TestCertExpiration(gopogh) Unknown
Docker_Windows (2 failed) TestErrorSpam/setup(gopogh) Unknown

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants