Support putting external images into the local registry of the kubevirtci cluster (#3801)

User can define an environment variable EXTRA_IMAGES that contains a list of
external image urls separated by spaces.

At the end of 'make cluster-up' target the EXTRA_IMAGES are processed
by a script ./cluster-up/extra-images.sh so that for each image url,
it pulls the image and then push the image into the local registry.

Then when 'make cluster-sync' is invoked, it searches all external
image urls in the generated yamls in _out/manifests/ and replaces
them with corresponding urls in the local registry (registry:5000)

Signed-off-by: Howard Gao <[email protected]>

Author: howardgao

cluster-sync/sync.sh

@@ -64,6 +64,17 @@ fi
 DOCKER_PREFIX=$MANIFEST_REGISTRY PULL_POLICY=$PULL_POLICY make manifests
 DOCKER_PREFIX=$DOCKER_PREFIX make push
 
+# Update manifests to replace extra images with internal registry ones
+if [ -n "${EXTRA_IMAGES}" ]; then
+    for img in ${EXTRA_IMAGES}; do
+        base_image_path="${img#*/}"
+        local_img_url="registry:5000/${base_image_path}"
+        for resfile in ./_out/manifests/*.yaml; do
+            sed -i "s|${img}|${local_img_url}|g" $resfile
+        done
+    done
+fi
+
 function kill_running_operator {
   out=$(_kubectl get pods -n $CDI_NAMESPACE)
   out=($out)

cluster-up/extra-images.sh

@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
+
+cri_bin=$1
+if [ -z $cri_bin ]; then
+    cri_bin=docker
+fi
+
+if [ -n "${EXTRA_IMAGES}" ]; then
+    registry_port=$(./cluster-up/cli.sh ports registry | xargs)
+    for img in ${EXTRA_IMAGES}; do
+        base_image_path="${img#*/}"
+        local_img_url="localhost:${registry_port}/${base_image_path}"
+        $cri_bin pull $img
+        $cri_bin tag $img $local_img_url
+        $cri_bin push $local_img_url
+    done
+fi

cluster-up/up.sh

@@ -36,3 +36,5 @@ up
 if [ ${KUBEVIRT_SINGLE_STACK} == true ]; then
     validate_single_stack_ipv6
 fi
+
+${KUBEVIRTCI_PATH}extra-images.sh $_cri_bin