Fix Shelly Gen 2 power_get() #1766
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix KeyError in shelly_gen2 power_get() function due to incorrect JSON response parsing. The current implementation attempts to access
response["output"]directly, but the Shelly Gen 2 RPC API returns the output field nested inside aresultobject.API Response Structure:
{ "id": 1, "result": { "output": true, "apower": 0.0, "voltage": 245.3 } }Fix:
Change r.json()["output"] to r.json()["result"]["output"] in line 30.
Testing:
Checklist