Skip to content

Move PR write permissions #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

Move PR write permissions #169

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdd93bc
Move PR write permissions
Aug 15, 2025
847c7d2
Split workflow into two jobs, replace some error messaging, other min…
Aug 15, 2025
c82e16a
Add logging and comments back
Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/create-preview-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ concurrency:
permissions:
contents: write # Required to checkout, create branches, and push
actions: read # Required to run the workflow
pull-requests: write # Required to comment on PRs

jobs:
create-preview:
permissions:
pull-requests: write # Required to comment on PRs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyurtsev I moved this to the job level because I didn't think there was a way to set permissions on an individual step. Is this what you were thinking or was there a different solution?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this change is the cause yet since it didn't fail on the step for commenting on the PR but the preview workflow failed: https://github.com/langchain-ai/docs/actions/runs/16992739025/job/48175935263?pr=169#step:11:892

runs-on: ubuntu-latest
env:
SOURCE_BRANCH: ${{ github.event_name == 'pull_request' && github.head_ref || github.ref_name }}
Expand Down
Loading