-
Notifications
You must be signed in to change notification settings - Fork 317
genai: improve _convert_pydantic_to_genai_function()
#1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Hardik450
wants to merge
7
commits into
langchain-ai:main
from
Hardik450:improve-pydantic-genai-conversio
Closed
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7b289d9
improve: enhanced _convert_pydantic_to_genai_function validation and …
Hardik450 fa1f107
Merge branch 'main' into improve-pydantic-genai-conversio
mdrxy 9bc0b30
Merge branch 'main' into improve-pydantic-genai-conversio
mdrxy 679c9f0
Update _function_utils.py
Hardik450 91ecd01
Update test_function_utils.py
Hardik450 c532527
Update test_function_utils.py
Hardik450 0c79f27
Merge branch 'main' into improve-pydantic-genai-conversio
mdrxy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add test and inline citation to the Gemini function tool schema? Also run lint please 🥺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, it will take time for me so i will try to make updates within 2 weeks.