Fixes AuthenticatesUsers always force remember me (#227)

Signed-off-by: Mior Muhammad Zaki <[email protected]>

Author: crynobone

auth-backend/AuthenticatesUsers.php

@@ -84,7 +84,7 @@ protected function validateLogin(Request $request)
     protected function attemptLogin(Request $request)
     {
         return $this->guard()->attempt(
-            $this->credentials($request), $request->filled('remember')
+            $this->credentials($request), $request->boolean('remember')
         );
     }
 

tests/AuthBackend/AuthenticatesUsersTest.php

@@ -2,10 +2,12 @@
 
 namespace Laravel\Ui\Tests\AuthBackend;
 
+use Illuminate\Auth\Events\Attempting;
 use Illuminate\Foundation\Auth\AuthenticatesUsers;
 use Illuminate\Http\Request;
 use Illuminate\Routing\Pipeline;
 use Illuminate\Support\Facades\Auth;
+use Illuminate\Support\Facades\Event;
 use Illuminate\Testing\TestResponse;
 use Illuminate\Validation\ValidationException;
 use Orchestra\Testbench\Factories\UserFactory;
@@ -35,18 +37,74 @@ protected function defineDatabaseMigrations()
     /** @test */
     public function it_can_authenticate_a_user()
     {
+        Event::fake();
+
+        $user = UserFactory::new()->create();
+
+        $request = Request::create('/login', 'POST', [
+            'email' => $user->email,
+            'password' => 'password',
+        ], [], [], [
+            'HTTP_ACCEPT' => 'application/json',
+        ]);
+
+        $response = $this->handleRequestUsing($request, function ($request) {
+            return $this->login($request);
+        })->assertStatus(204);
+
+        Event::assertDispatched(function (Attempting $event) {
+            return $event->remember === false;
+        });
+    }
+
+    /** @test */
+    public function it_can_authenticate_a_user_with_remember_as_false()
+    {
+        Event::fake();
+
+        $user = UserFactory::new()->create();
+
+        $request = Request::create('/login', 'POST', [
+            'email' => $user->email,
+            'password' => 'password',
+            'remember' => false,
+        ], [], [], [
+            'HTTP_ACCEPT' => 'application/json',
+        ]);
+
+        $response = $this->handleRequestUsing($request, function ($request) {
+            return $this->login($request);
+        })->assertStatus(204);
+
+        Event::assertDispatched(function (Attempting $event) {
+            return $event->remember === false;
+        });
+    }
+
+
+
+    /** @test */
+    public function it_can_authenticate_a_user_with_remember_as_true()
+    {
+        Event::fake();
+
         $user = UserFactory::new()->create();
 
         $request = Request::create('/login', 'POST', [
             'email' => $user->email,
             'password' => 'password',
+            'remember' => true,
         ], [], [], [
             'HTTP_ACCEPT' => 'application/json',
         ]);
 
         $response = $this->handleRequestUsing($request, function ($request) {
             return $this->login($request);
         })->assertStatus(204);
+
+        Event::assertDispatched(function (Attempting $event) {
+            return $event->remember === true;
+        });
     }
 
     /** @test */