style: [sdk-1577] fixing lint issues

Author: joker23

packages/shared/common/src/internal/fdv2/FDv2ChangeSetBuilder.ts

@@ -1,4 +1,4 @@
-import { PutObject, DeleteObject, Event } from './proto';
+import { DeleteObject, Event, PutObject } from './proto';
 
 // eventually this will be the same as the IntentCode type, but for now we'll use a simpler type
 type supportedIntentCodes = 'xfer-full';
@@ -13,15 +13,15 @@ type supportedIntentCodes = 'xfer-full';
  * compatibility guarantees or semantic versioning. It is not suitable for production usage.
  */
 export default class FDv2ChangeSetBuilder {
-  private intent?: supportedIntentCodes;
-  private events: Event[] = [];
+  private _intent?: supportedIntentCodes;
+  private _events: Event[] = [];
 
   /**
    * Begins a new change set with a given intent.
    */
   start(intent: supportedIntentCodes): this {
-    this.intent = intent;
-    this.events = [];
+    this._intent = intent;
+    this._events = [];
 
     return this;
   }
@@ -33,7 +33,7 @@ export default class FDv2ChangeSetBuilder {
    * resetting some values in the future.
    */
   finish(): Array<Event> {
-    if (this.intent === undefined) {
+    if (this._intent === undefined) {
       throw new Error('changeset: cannot complete without a server-intent');
     }
 
@@ -45,16 +45,17 @@ export default class FDv2ChangeSetBuilder {
       {
         event: 'server-intent',
         data: {
-          payloads: [{
+          payloads: [
+            {
               id: 'dummy-id',
               target: 1,
-              intentCode: this.intent,
+              intentCode: this._intent!,
               reason: 'payload-missing',
             },
-          ]
-        }
+          ],
+        },
       },
-      ...this.events,
+      ...this._events,
       {
         event: 'payload-transferred',
         data: {
@@ -63,7 +64,7 @@ export default class FDv2ChangeSetBuilder {
           state: '',
           version: 1,
           id: 'dummy-id',
-        }
+        },
       },
     ];
 
@@ -74,23 +75,23 @@ export default class FDv2ChangeSetBuilder {
    * Adds a new object to the changeset.
    */
   putObject(obj: PutObject): this {
-    this.events.push({
+    this._events.push({
       event: 'put-object',
       data: obj,
     });
 
-    return this
+    return this;
   }
 
   /**
    * Adds a deletion to the changeset.
    */
   deleteObject(obj: DeleteObject): this {
-    this.events.push({
+    this._events.push({
       event: 'delete-object',
-      data: obj
+      data: obj,
     });
 
-    return this
+    return this;
   }
 }

packages/shared/common/src/internal/fdv2/index.ts

@@ -1,3 +1,4 @@
+import FDv2ChangeSetBuilder from './FDv2ChangeSetBuilder';
 import {
   FDv2EventsCollection,
   Payload,
@@ -6,7 +7,6 @@ import {
   Update,
 } from './payloadProcessor';
 import { PayloadStreamReader } from './payloadStreamReader';
-import FDv2ChangeSetBuilder from './FDv2ChangeSetBuilder';
 
 export {
   FDv2EventsCollection,

packages/shared/common/src/internal/fdv2/payloadProcessor.ts

@@ -224,7 +224,8 @@ export class PayloadProcessor {
       // server intent hasn't been received yet.
       !this._tempId ||
       // selector can be an empty string if we are using a file data initilizer
-      (data.state === null || data.state === undefined) ||
+      data.state === null ||
+      data.state === undefined ||
       !data.version
     ) {
       this._resetAll(); // a reset is best defensive action since payload transferred terminates a payload

packages/shared/common/src/internal/fdv2/proto.ts

@@ -1,10 +1,23 @@
-export type EventType = 'server-intent' | 'put-object' | 'delete-object' | 'payload-transferred' | 'goodbye' | 'error'| 'heart-beat';
+export type EventType =
+  | 'server-intent'
+  | 'put-object'
+  | 'delete-object'
+  | 'payload-transferred'
+  | 'goodbye'
+  | 'error'
+  | 'heart-beat';
 export type IntentCode = 'xfer-full' | 'xfer-changes' | 'none';
 export type ObjectKind = 'flag' | 'segment';
 
 export interface Event {
   event: EventType;
-  data: ServerIntentData | PutObject | DeleteObject | PayloadTransferred | GoodbyeObject | ErrorObject;
+  data:
+    | ServerIntentData
+    | PutObject
+    | DeleteObject
+    | PayloadTransferred
+    | GoodbyeObject
+    | ErrorObject;
 }
 
 export interface ServerIntentData {

packages/shared/sdk-server/src/LDClientImpl.ts

@@ -43,8 +43,8 @@ import BigSegmentStoreStatusProvider from './BigSegmentStatusProviderImpl';
 import { createPluginEnvironmentMetadata } from './createPluginEnvironmentMetadata';
 import { createPayloadListener } from './data_sources/createPayloadListenerFDv2';
 import { createStreamListeners } from './data_sources/createStreamListeners';
-import FileDataInitializerFDv2 from './data_sources/fileDataInitilizerFDv2';
 import DataSourceUpdates from './data_sources/DataSourceUpdates';
+import FileDataInitializerFDv2 from './data_sources/fileDataInitilizerFDv2';
 import OneShotInitializerFDv2 from './data_sources/OneShotInitializerFDv2';
 import PollingProcessor from './data_sources/PollingProcessor';
 import PollingProcessorFDv2 from './data_sources/PollingProcessorFDv2';
@@ -335,13 +335,7 @@ function constructFDv2(
           ),
       );
     } else if (dataSystem.dataSource?.initializerOptions?.type === 'file') {
-      initializers.push(
-        () =>
-          new FileDataInitializerFDv2(
-            config,
-            platform,
-          ),
-      );
+      initializers.push(() => new FileDataInitializerFDv2(config, platform));
     }
 
     const synchronizers: subsystem.LDDataSourceFactory[] = [];

packages/shared/sdk-server/src/api/options/LDDataSystemOptions.ts

@@ -84,15 +84,15 @@ export interface FileDataInitializerOptions {
   type: 'file';
   paths: Array<string>;
   yamlParser?: (data: string) => any;
-};
+}
 
 /**
  * Initializer option to initilize the SDK from doing a one time full payload transfer.
  * This will be the default initializer used by the standard data source type.
  */
 export interface PollingDataInitializerOptions {
   type: 'polling';
-};
+}
 
 /**
  * This standard data source is the recommended datasource for most customers. It will use

packages/shared/sdk-server/src/data_sources/fileDataInitilizerFDv2.ts

@@ -8,11 +8,11 @@ import {
   subsystem as subsystemCommon,
 } from '@launchdarkly/js-sdk-common';
 
+import { FileDataInitializerOptions } from '../api';
 import { Flag } from '../evaluation/data/Flag';
 import { Segment } from '../evaluation/data/Segment';
-import { processFlag, processSegment } from '../store/serialization';
 import Configuration from '../options/Configuration';
-import { FileDataInitializerOptions } from '../api';
+import { processFlag, processSegment } from '../store/serialization';
 import FileLoader from './FileLoader';
 
 /**
@@ -26,11 +26,8 @@ export default class FileDataInitializerFDv2 implements subsystemCommon.DataSour
   private _fileLoader?: FileLoader;
 
   // TODO: do a options check here
-  constructor(
-    config: Configuration,
-    platform: Platform
-  ) {
-    const options = config.dataSystem?.dataSource?.initializerOptions as FileDataInitializerOptions
+  constructor(config: Configuration, platform: Platform) {
+    const options = config.dataSystem?.dataSource?.initializerOptions as FileDataInitializerOptions;
     this._validateInputs(options, platform);
 
     this._paths = options.paths;
@@ -56,7 +53,8 @@ export default class FileDataInitializerFDv2 implements subsystemCommon.DataSour
     statusCallback(subsystemCommon.DataSourceState.Initializing);
     const initMetadata = internal.initMetadataFromHeaders(undefined);
 
-    const payloadProcessor = new internal.PayloadProcessor({
+    const payloadProcessor = new internal.PayloadProcessor(
+      {
         flag: (flag: Flag) => {
           processFlag(flag);
           return flag;
@@ -102,56 +100,59 @@ export default class FileDataInitializerFDv2 implements subsystemCommon.DataSour
           );
         }
       },
-    )
+    );
 
-    this._fileLoader.loadAndWatch()
+    this._fileLoader.loadAndWatch();
   }
 
-  _processFileData(results: { path: string; data: string }[]) {
-    const combined: any = results.reduce((acc, curr) => {
-      let parsed: any;
-      if (curr.path.endsWith('.yml') || curr.path.endsWith('.yaml')) {
-        if (this._yamlParser) {
-          parsed = this._yamlParser(curr.data);
+  private _processFileData(results: { path: string; data: string }[]) {
+    const combined: any = results.reduce(
+      (acc, curr) => {
+        let parsed: any;
+        if (curr.path.endsWith('.yml') || curr.path.endsWith('.yaml')) {
+          if (this._yamlParser) {
+            parsed = this._yamlParser(curr.data);
+          } else {
+            throw new Error(`Attempted to parse yaml file (${curr.path}) without parser.`);
+          }
         } else {
-          throw new Error(`Attempted to parse yaml file (${curr.path}) without parser.`);
-        }
-      } else {
-        parsed = JSON.parse(curr.data);
-      }
-      return {
-        segments: {
-          ...acc.segments,
-          ...parsed.segments,
-        },
-        flags: {
-          ...acc.flags,
-          ...parsed.flags,
+          parsed = JSON.parse(curr.data);
         }
-      }
-    }, {
-      segments: {},
-      flags: {},
-    });
+        return {
+          segments: {
+            ...acc.segments,
+            ...parsed.segments,
+          },
+          flags: {
+            ...acc.flags,
+            ...parsed.flags,
+          },
+        };
+      },
+      {
+        segments: {},
+        flags: {},
+      },
+    );
 
-    const changeSetBuilder = new internal.FDv2ChangeSetBuilder()
-    changeSetBuilder.start('xfer-full')
+    const changeSetBuilder = new internal.FDv2ChangeSetBuilder();
+    changeSetBuilder.start('xfer-full');
 
-    Object.keys(combined).forEach((kind : string) => {
+    Object.keys(combined).forEach((kind: string) => {
       Object.entries<any>(combined[kind]).forEach(([k, v]) => {
-          changeSetBuilder.putObject({
-            // strong assumption here that we only have segments and flags.
-            kind: kind === 'segments' ? 'segment' : 'flag',
-            key: k,
-            version: v.version || 1,
-            object: v
-          })
-        })
+        changeSetBuilder.putObject({
+          // strong assumption here that we only have segments and flags.
+          kind: kind === 'segments' ? 'segment' : 'flag',
+          key: k,
+          version: v.version || 1,
+          object: v,
+        });
       });
+    });
 
     return {
-      events: changeSetBuilder.finish()
-    }
+      events: changeSetBuilder.finish(),
+    };
   }
 
   stop() {