From 20e2fb897dcbcb6bb6d7d50107e5ac18a0a76bf5 Mon Sep 17 00:00:00 2001 From: Federico Badini Date: Wed, 20 Jan 2021 15:44:36 +0100 Subject: [PATCH] Fix onValueChange called twice --- src/index.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/index.js b/src/index.js index bcbc93e8..823bbfa9 100644 --- a/src/index.js +++ b/src/index.js @@ -158,8 +158,6 @@ export default class RNPickerSelect extends PureComponent { !isEqual(this.props.value, undefined) && !isEqual(prevState.selectedItem, selectedItem); if (itemsChanged || selectedItemChanged) { - this.props.onValueChange(selectedItem.value, idx); - this.setState({ ...(itemsChanged ? { items } : {}), ...(selectedItemChanged ? { selectedItem } : {}), @@ -182,13 +180,11 @@ export default class RNPickerSelect extends PureComponent { onValueChange(value, index) { const { onValueChange } = this.props; - onValueChange(value, index); - this.setState((prevState) => { return { selectedItem: prevState.items[index], }; - }); + }, () => onValueChange(value, index)); } onOrientationChange({ nativeEvent }) {