Skip to content

SDL_GL_CONTEXT_EGL should be removed #1025

@SDLBugzilla

Description

@SDLBugzilla

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2013-08-14 23:56:07 +0000, Gabriel Jacobo wrote:

SDL_GL_CONTEXT_EGL and the associated gl_config.use_egl flag should be removed, and instead we should decide what sort of context needs to be created exclusively by checking SDL_GL_CONTEXT_PROFILE_MASK (i.e., gl_config.profile_mask == SDL_GL_CONTEXT_PROFILE_ES would do the work of use_egl).

If we use EGL to make the GL ES context internally it's another matter entirely.

On 2013-08-15 01:49:01 +0000, Alex Szpakowski wrote:

On some systems, EGL can be used to create a regular OpenGL context I believe: http://www.khronos.org/registry/egl/sdk/docs/man/xhtml/eglBindAPI.html

If this isn't what SDL does when SDL_GL_CONTEXT_EGL is specified, maybe it should.

On 2013-08-15 01:59:07 +0000, Alex Szpakowski wrote:

EGL also has an extension which mirrors the functionality of WGL_ARB_create_context and GLX_ARB_create_context for choosing the GL version and making core / debug / etc. contexts: http://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_create_context.txt

On 2013-08-19 20:01:05 +0000, Gabriel Jacobo wrote:

The EGL stuff is so intermixed with the ES stuff that the configure script for Linux wouldn't check the ES headers if the EGL headers where not available.

I'm not against having SDL_GL_CONTEXT_EGL mean "use EGL internally but obey SDL_GL_CONTEXT_PROFILE_MASK too", it will have to be implemented though! I don't clearly see what the upside would be...work around buggy implementations on certain platforms?

On 2013-08-20 00:00:04 +0000, Ryan C. Gordon wrote:

My two cents:

I'm totally for removing SDL_GL_CONTEXT_EGL ... before I knew what EGL was, I thought it meant "I want an OpenGL ES context," and couldn't understand why we have two different flags to ask for that.

My thought is that there's a right way to get GL (or ES) on a given video target, and the app shouldn't care which SDL chooses.

The flag can stay for 2.0.x, but be ignored by SDL, and removed in 2.1.

--ryan.

On 2013-08-29 18:05:31 +0000, Gabriel Jacobo wrote:

http://hg.libsdl.org/SDL/rev/aea98cc3e696

I didn't remove use_egl from gl_config because I'm not sure what impact, if any, changing the size of the struct has on binary compatibility.

Changing version to 2.1 so we remember to remove SDL_GL_CONTEXT_EGL then.

On 2013-09-05 13:13:49 +0000, Sam Lantinga wrote:

You can safely remove use_egl from gl_config. That's an internal structure so it won't affect the ABI.

On 2015-02-19 05:22:21 +0000, Ryan C. Gordon wrote:

Marking a large number of bugs with the "triage-2.0.4" keyword at once. Sorry if you got a lot of email from this. This is to help me sort through some bugs in regards to a 2.0.4 release. We may or may not fix this bug for 2.0.4, though!

Metadata

Metadata

Assignees

No one assigned

    Labels

    break-compatBreaks API/ABI, maybe for next major version bump

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions