Skip to content

Commit e2db7c7

Browse files
committed
Avoid explicit panics in handle_event
Previously, we'd explicitly `panic` on an APIMisuseError. While this error type should still never happen, we avoid explicit panics in favor of `debug_assert`s here.
1 parent ea902a8 commit e2db7c7

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/event.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,12 @@ where
542542
match result {
543543
Ok(()) => {},
544544
Err(APIError::APIMisuseError { err }) => {
545-
log_error!(self.logger, "Panicking due to APIMisuseError: {}", err);
546-
panic!("APIMisuseError: {}", err);
545+
log_error!(
546+
self.logger,
547+
"Encountered APIMisuseError, this should never happen: {}",
548+
err
549+
);
550+
debug_assert!(false, "APIMisuseError: {}", err);
547551
},
548552
Err(APIError::ChannelUnavailable { err }) => {
549553
log_error!(
@@ -571,7 +575,7 @@ where
571575
)
572576
.unwrap_or_else(|e| {
573577
log_error!(self.logger, "Failed to force close channel after funding generation failed: {:?}", e);
574-
panic!(
578+
debug_assert!(false,
575579
"Failed to force close channel after funding generation failed"
576580
);
577581
});

0 commit comments

Comments
 (0)