Skip to content

Commit 9150f28

Browse files
Test no_std in CI (#239)
This builds on #238 and contains the same commit. This has a change to only run `no_std` checks on the libraries since examples and such aren't likely to be `no_std`, nor do they need to be.
1 parent f688166 commit 9150f28

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,8 @@ jobs:
111111
with:
112112
save-if: ${{ github.event_name != 'merge_group' }}
113113

114-
# TODO: Add --target x86_64-unknown-none to the no_std check once we solve the compilation issues with it.
115-
# https://github.com/linebender/parley/issues/86
116114
- name: cargo clippy (no_std)
117-
run: cargo hack clippy --workspace --locked --optional-deps --each-feature --ignore-unknown-features --features libm --exclude-features ${{ env.FEATURES_DEPENDING_ON_STD }} -- -D warnings
115+
run: cargo hack clippy ${{ env.RUST_MIN_VER_PKGS }} --locked --optional-deps --each-feature --ignore-unknown-features --features libm --exclude-features ${{ env.FEATURES_DEPENDING_ON_STD }} --target x86_64-unknown-none -- -D warnings
118116

119117
- name: cargo clippy
120118
run: cargo hack clippy --workspace --locked --optional-deps --each-feature --ignore-unknown-features --features std -- -D warnings
@@ -197,6 +195,7 @@ jobs:
197195
uses: dtolnay/rust-toolchain@master
198196
with:
199197
toolchain: ${{ env.RUST_MIN_VER }}
198+
targets: x86_64-unknown-none
200199

201200
- name: install cargo-hack
202201
uses: taiki-e/install-action@v2
@@ -208,10 +207,8 @@ jobs:
208207
with:
209208
save-if: ${{ github.event_name != 'merge_group' }}
210209

211-
# TODO: Add --target x86_64-unknown-none to the no_std check once we solve the compilation issues with it.
212-
# https://github.com/linebender/parley/issues/86
213210
- name: cargo check (no_std)
214-
run: cargo hack check ${{ env.RUST_MIN_VER_PKGS }} --locked --optional-deps --each-feature --ignore-unknown-features --features libm --exclude-features ${{ env.FEATURES_DEPENDING_ON_STD }}
211+
run: cargo hack check ${{ env.RUST_MIN_VER_PKGS }} --locked --optional-deps --each-feature --ignore-unknown-features --features libm --exclude-features ${{ env.FEATURES_DEPENDING_ON_STD }} --target x86_64-unknown-none
215212

216213
- name: cargo check
217214
run: cargo hack check ${{ env.RUST_MIN_VER_PKGS }} --locked --optional-deps --each-feature --ignore-unknown-features --features std

0 commit comments

Comments
 (0)