feat(meetings): replace link extraction with attachment api (LFXV2-743) (#154)

* feat(meetings): replace link extraction with attachment API (LFXV2-743)

Replace the existing implementation where links are extracted from meeting
descriptions with the attachment API that supports link-type attachments.

Changes:
- Remove extractUrlsWithDomains usage and importantLinks signals from
  meeting-join and meeting-card components
- Update templates to display both file and link attachments uniformly
- Add saveLinkAttachments() method to create link attachments from
  important_links FormArray
- Add populateExistingLinks() to load existing links when editing
- Add deleteLinkAttachment() handler for tracking link deletions
- Update saveLinkAttachments() to only create new links (without uid)
- Fix icon alignment with consistent w-8 width for both file and link icons

Benefits:
- Eliminates duplicate link display from extracted URLs and attachments
- Provides consistent CRUD operations for all meeting resources
- Links persist as structured data with proper tracking

Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Asitha de Silva <[email protected]>

* fix(meetings): improve type safety and fix attachment logic

- Add ImportantLinkFormValue interface for form-specific link data
- Replace any types with proper TypeScript interfaces
- Fix pending deletions logic to clear on completion without failures
- Fix attachment view/download buttons to check type instead of link field

LFXV2-743

Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Asitha de Silva <[email protected]>

---------

Signed-off-by: Asitha de Silva <[email protected]>

Author: asithade

apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html

@@ -237,15 +237,19 @@ <h3 class="text-gray-600 text-sm font-normal">Resources</h3>
                   <div class="flex flex-col gap-2">
                     @for (attachment of attachments(); track attachment.uid; let i = $index) {
                       <a
-                        [href]="'/api/meetings/' + meeting().uid + '/attachments/' + attachment.uid"
+                        [href]="attachment.type === 'link' ? attachment.link : '/api/meetings/' + meeting().uid + '/attachments/' + attachment.uid"
                         target="_blank"
                         rel="noopener noreferrer"
                         class="bg-gray-200 hover:bg-gray-300 rounded px-3 py-2 flex items-center gap-3 min-w-[180px] transition-colors cursor-pointer"
                         [attr.data-testid]="'meeting-attachment-' + i">
-                        <!-- File Icon -->
-                        <i [class]="(attachment.mime_type || '' | fileTypeIcon) + ' text-3xl text-black'"></i>
-
-                        <!-- File Name -->
+                        <!-- Icon - File or Link -->
+                        @if (attachment.type === 'link') {
+                          <i class="fa-light fa-arrow-up-right-from-square text-3xl text-black w-8 flex-shrink-0"></i>
+                        } @else {
+                          <i [class]="(attachment.mime_type || '' | fileTypeIcon) + ' text-3xl text-black w-8 flex-shrink-0'"></i>
+                        }
+
+                        <!-- Attachment Name -->
                         <span class="text-sm text-neutral-950 overflow-ellipsis overflow-hidden whitespace-nowrap flex-1 font-sans">{{ attachment.name }}</span>
                       </a>
                     }

apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts

@@ -18,16 +18,7 @@ import { MeetingRegistrantsComponent } from '@components/meeting-registrants/mee
 import { MeetingRsvpDetailsComponent } from '@components/meeting-rsvp-details/meeting-rsvp-details.component';
 import { RsvpButtonGroupComponent } from '@components/rsvp-button-group/rsvp-button-group.component';
 import { environment } from '@environments/environment';
-import {
-  canJoinMeeting,
-  extractUrlsWithDomains,
-  getCurrentOrNextOccurrence,
-  Meeting,
-  MeetingAttachment,
-  MeetingOccurrence,
-  Project,
-  User,
-} from '@lfx-one/shared';
+import { canJoinMeeting, getCurrentOrNextOccurrence, Meeting, MeetingAttachment, MeetingOccurrence, Project, User } from '@lfx-one/shared';
 import { FileTypeIconPipe } from '@pipes/file-type-icon.pipe';
 import { MeetingTimePipe } from '@pipes/meeting-time.pipe';
 import { MeetingService } from '@services/meeting.service';
@@ -78,7 +69,6 @@ export class MeetingJoinComponent {
   public meeting: Signal<Meeting & { project: Project }>;
   public currentOccurrence: Signal<MeetingOccurrence | null>;
   public meetingTypeBadge: Signal<{ badgeClass: string; icon?: string; text: string } | null>;
-  public importantLinks: Signal<{ url: string; domain: string }[]>;
   public returnTo: Signal<string | undefined>;
   public password: WritableSignal<string | null> = signal<string | null>(null);
   public canJoinMeeting: Signal<boolean>;
@@ -103,7 +93,6 @@ export class MeetingJoinComponent {
     this.joinForm = this.initializeJoinForm();
     this.formValues = this.initializeFormValues();
     this.meetingTypeBadge = this.initializeMeetingTypeBadge();
-    this.importantLinks = this.initializeImportantLinks();
     this.returnTo = this.initializeReturnTo();
     this.canJoinMeeting = this.initializeCanJoinMeeting();
     this.fetchedJoinUrl = this.initializeFetchedJoinUrl();
@@ -268,20 +257,6 @@ export class MeetingJoinComponent {
     });
   }
 
-  private initializeImportantLinks(): Signal<{ url: string; domain: string }[]> {
-    return computed(() => {
-      const meeting = this.meeting();
-      const currentOccurrence = this.currentOccurrence();
-
-      // Use current occurrence description if available, otherwise fallback to meeting description
-      const description = currentOccurrence?.description || meeting?.description;
-      if (!description) {
-        return [];
-      }
-      return extractUrlsWithDomains(description);
-    });
-  }
-
   private initializeReturnTo(): Signal<string | undefined> {
     return computed(() => {
       return `${environment.urls.home}/meetings/${this.meeting().uid}?password=${this.password()}`;

apps/lfx-one/src/app/modules/project/committees/components/upcoming-committee-meeting/upcoming-committee-meeting.component.html

@@ -7,7 +7,7 @@
       <a
         [routerLink]="['/project', project()?.slug, 'meetings', upcomingMeeting()!.uid]"
         class="text-sm font-medium text-primary hover:text-primary-600 hover:underline line-clamp-2"
-        [title]="upcomingMeeting()!.title || 'Meeting'">
+        [pTooltip]="upcomingMeeting()!.title || 'Meeting'">
         {{ upcomingMeeting()!.title || 'Meeting' }}
       </a>
     </div>

apps/lfx-one/src/app/modules/project/dashboard/project-dashboard/project.component.html

@@ -183,7 +183,7 @@ <h3 class="text-sm font-display text-gray-500">Upcoming Meetings</h3>
                       <ng-template #body let-row>
                         <tr>
                           <td class="w-1/2 max-w-0">
-                            <a class="block truncate text-sm" [title]="row.title" [routerLink]="[row.url]" [relativeTo]="activatedRoute">{{ row.title }}</a>
+                            <a class="block truncate text-sm" [pTooltip]="row.title" [routerLink]="[row.url]" [relativeTo]="activatedRoute">{{ row.title }}</a>
                           </td>
                           <td class="w-1/2">
                             <div class="flex justify-end whitespace-nowrap">
@@ -242,7 +242,7 @@ <h3 class="text-sm font-display text-gray-500">Recently Updated Committees</h3>
                       <ng-template #body let-row>
                         <tr>
                           <td class="w-1/2 max-w-0">
-                            <a class="block truncate text-sm" [title]="row.title" [routerLink]="row.url">{{ row.title }}</a>
+                            <a class="block truncate text-sm" [pTooltip]="row.title" [routerLink]="row.url">{{ row.title }}</a>
                           </td>
                           <td class="w-1/2">
                             <div class="flex justify-end whitespace-nowrap">

apps/lfx-one/src/app/modules/project/meetings/components/meeting-manage/meeting-manage.component.html

@@ -55,8 +55,11 @@ <h1 class="text-xl font-semibold text-slate-900" data-testid="meeting-manage-tit
                   [existingAttachments]="attachments()"
                   [isEditMode]="isEditMode()"
                   [deletingAttachmentId]="deletingAttachmentId()"
+                  [pendingAttachmentDeletions]="pendingAttachmentDeletions()"
                   (goToStep)="goToStep($event)"
-                  (deleteAttachment)="deleteAttachment($event)">
+                  (deleteAttachment)="deleteAttachment($event)"
+                  (undoDeleteAttachment)="undoDeleteAttachment($event)"
+                  (deleteLinkAttachment)="deleteLinkAttachment($event)">
                 </lfx-meeting-resources-summary>
               </ng-template>
             </p-step-panel>
@@ -114,8 +117,10 @@ <h2 class="text-lg font-semibold text-slate-900 mb-4">Resources & Summary</h2>
                     [existingAttachments]="attachments()"
                     [isEditMode]="isEditMode()"
                     [deletingAttachmentId]="deletingAttachmentId()"
+                    [pendingAttachmentDeletions]="pendingAttachmentDeletions()"
                     (goToStep)="goToStep($event)"
-                    (deleteAttachment)="deleteAttachment($event)">
+                    (deleteAttachment)="deleteAttachment($event)"
+                    (undoDeleteAttachment)="undoDeleteAttachment($event)">
                   </lfx-meeting-resources-summary>
                 </div>
               </div>