Skip to content

Commit 7313a81

Browse files
Add last processed remote message id when adding to cache also as the… (#1144)
* Add last processed remote message id when adding to cache also as the returned message could be sent on the wire * generated protobuf * clean up --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
1 parent afef3ef commit 7313a81

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

signalling/signalcache.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func (s *SignalCache) SetLastProcessedRemoteMessageId(lastProcessedRemoteMessage
7272
s.lastProcessedRemoteMessageId = lastProcessedRemoteMessageId
7373
}
7474

75-
func (s *SignalCache) Add(msg proto.Message, messageId uint32) {
75+
func (s *SignalCache) Add(msg proto.Message, messageId uint32) uint32 {
7676
s.lock.Lock()
7777
defer s.lock.Unlock()
7878

@@ -85,6 +85,8 @@ func (s *SignalCache) Add(msg proto.Message, messageId uint32) {
8585
})
8686
}
8787
s.messages.Insert(rindex+1, elem)
88+
89+
return s.lastProcessedRemoteMessageId
8890
}
8991

9092
func (s *SignalCache) Clear(till uint32) {

signalling/signalv2clientmessagecache.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func (s *Signalv2ClientMessageCache) Add(msg *livekit.Signalv2ClientMessage) *li
3535
msg.Sequencer = &livekit.Sequencer{
3636
MessageId: messageId,
3737
}
38-
s.SignalCache.Add(msg, messageId)
38+
msg.Sequencer.LastProcessedRemoteMessageId = s.SignalCache.Add(msg, messageId)
3939
return msg
4040
}
4141

signalling/signalv2servermessagecache.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func (s *Signalv2ServerMessageCache) Add(msg *livekit.Signalv2ServerMessage) *li
3535
msg.Sequencer = &livekit.Sequencer{
3636
MessageId: messageId,
3737
}
38-
s.SignalCache.Add(msg, messageId)
38+
msg.Sequencer.LastProcessedRemoteMessageId = s.SignalCache.Add(msg, messageId)
3939
return msg
4040
}
4141

0 commit comments

Comments
 (0)