Skip to content

Commit 93319bf

Browse files
Filling out some messages that are unlikely to change in v2. (#1137)
* Filling out some messages that are unlikely to change in v2. * generated protobuf * comment * mage * generated protobuf --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
1 parent c700929 commit 93319bf

File tree

6 files changed

+161
-36
lines changed

6 files changed

+161
-36
lines changed

livekit/livekit_models.pb.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

livekit/livekit_rtc.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

livekit/livekit_rtc_v2.pb.go

Lines changed: 147 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protobufs/livekit_models.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ message DataPacket {
293293
}
294294

295295
message ActiveSpeakerUpdate {
296+
option deprecated = true;
296297
repeated SpeakerInfo speakers = 1;
297298
}
298299

protobufs/livekit_rtc.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ import "livekit_models.proto";
2323

2424
message SignalRequest {
2525
oneof message {
26-
// initial join exchange, for publisher
26+
// participant offer for publisher
2727
SessionDescription offer = 1;
28-
// participant answering publisher offer
28+
// participant answering subscriber offer
2929
SessionDescription answer = 2;
3030
TrickleRequest trickle = 3;
3131
AddTrackRequest add_track = 4;

protobufs/livekit_rtc_v2.proto

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ message Signalv2ClientMessage {
5050

5151
oneof message {
5252
ConnectRequest connect_request = 2;
53+
SessionDescription publisher_sdp = 3; // SDP offer for publisher peer connection
54+
SessionDescription subscriber_sdp = 4; // SDP answer for subscriber peer connection
5355
}
5456
}
5557

@@ -58,6 +60,10 @@ message Signalv2ServerMessage {
5860

5961
oneof message {
6062
ConnectResponse connect_response = 2;
63+
SessionDescription publisher_sdp = 3; // SDP answer for publisher peer connection
64+
SessionDescription subscriber_sdp = 4; // SDP offer for subscriber peer connection
65+
RoomUpdate room_update = 5;
66+
ParticipantUpdate participant_update = 6;
6167
}
6268
}
6369

0 commit comments

Comments
 (0)