ai/live: Update to golang 1.25 (#3745)

The golang 1.25 update turned out into something of an ordeal, so
splitting it up from #3739
to allow for better review.

While everything compiled in 1.25, some tests and CI steps broke.

* Go lint needed to be updated to v2+ to support golang 1.25
* Bumping go vet from v1 to v2 entailed a bunch of CLI changes.
  Tried to make those 1-to-1 as much as possible, however:

  Go fmt now needs to be invoked separately for golint. We check
  go fmt in the CI step right before lint ... so just remove the
  go fmt step?

  The revive linter flagged a ton of missing comments. But it
  seems the linter only applies to the `pm` and `verification`
  packages which hardly change. Rather than update those packages,
  remove the use of the `revive` linter.

* Some linting step (not sure which one? vet?) now complains
  about format string functions being used incorrectly, eg
  using a variable in place of a format string literal.
  Those were fixed in the code.

* The `rand.Seed` function apparently became a no-op as of
  golang 1.24 and that broke most of our tests that use the RNG.
  Removed the init() function that sets the seed, and added a
  package level RNG context (using the same seed as the old init)
  and updated any failing tests to use that context.

  Not all uses of the RNG were updated, just ones that broke tests.
  The global RNG is safely initialized so we can continue to use it
  by default in the code that still uses it without test coverage.

* Fix race condition in discovery uncovered by golang 1.25

Author: j0sh

.github/workflows/test.yaml

@@ -108,11 +108,11 @@ jobs:
           git diff --exit-code
 
       - name: Lint
-        uses: golangci/golangci-lint-action@v4
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: v1.61.0
+          version: v2.4.0
           skip-pkg-cache: true
-          args: '--out-format=colored-line-number --disable-all --enable=gofmt --enable=govet --enable=revive --timeout=4m pm verification'
+          args: '--output.text.path=stdout --output.text.colors=true --output.text.print-issued-lines=true --default=none --enable=govet --timeout=4m pm verification'
 
       - name: Run Revive Action by building from repository
         uses: docker://morphy/revive-action:v2

cmd/livepeer/starter/starter.go

@@ -748,7 +748,7 @@ func StartLivepeer(ctx context.Context, cfg LivepeerConfig) {
 				}
 			}
 		} else {
-			glog.Exit(fmt.Errorf(err.Error()))
+			glog.Exit(err)
 		}
 
 		//Get the Eth client connection information

cmd/livepeer_cli/wizard.go

@@ -164,7 +164,7 @@ func (w *wizard) readDefaultInt(def int) int {
 
 func (w *wizard) readBigInt(prompt string) *big.Int {
 	for {
-		fmt.Printf(fmt.Sprintf("%s - > ", prompt))
+		fmt.Print(fmt.Sprintf("%s - > ", prompt))
 		text, err := w.in.ReadString('\n')
 		if err != nil {
 			log.Crit("Failed to read user input", "err", err)

cmd/livepeer_cli/wizard_transcoder.go

@@ -427,7 +427,7 @@ func (w *wizard) setMaxSessions() {
 	}
 	result, ok := httpPostWithParams(fmt.Sprintf("http://%v:%v/setMaxSessions", w.host, w.httpPort), data)
 	if ok {
-		fmt.Printf(result)
+		fmt.Print(result)
 		return
 	} else {
 		fmt.Printf("Error setting max sessions: %v", result)

common/util.go

@@ -2,6 +2,7 @@ package common
 
 import (
 	"context"
+	"encoding/binary"
 	"encoding/hex"
 	"encoding/json"
 	"fmt"
@@ -88,10 +89,6 @@ var (
 	}
 )
 
-func init() {
-	rand.Seed(time.Now().UnixNano())
-}
-
 func ParseBigInt(num string) (*big.Int, error) {
 	bigNum := new(big.Int)
 	_, ok := bigNum.SetString(num, 10)
@@ -312,6 +309,9 @@ func ratToFixed(rat *big.Rat, scalingFactor int64) (int64, error) {
 	return fp, nil
 }
 
+// Package-level RNG; tests can override it.
+var PkgRNG = rand.New(rand.NewSource(time.Now().UnixNano()))
+
 // RandomIDGenerator generates random hexadecimal string of specified length
 // defined as variable for unit tests
 var RandomIDGenerator = func(length uint) string {
@@ -320,9 +320,7 @@ var RandomIDGenerator = func(length uint) string {
 
 var RandomBytesGenerator = func(length uint) []byte {
 	x := make([]byte, length, length)
-	for i := 0; i < len(x); i++ {
-		x[i] = byte(rand.Uint32())
-	}
+	PkgRNG.Read(x)
 	return x
 }
 
@@ -335,6 +333,10 @@ var RandomUintUnder = func(max uint) uint {
 	return uint(rand.Uint32()) % max
 }
 
+func RandomUint64() uint64 {
+	return binary.LittleEndian.Uint64(RandomBytesGenerator(8))
+}
+
 func ToInt64(val *big.Int) int64 {
 	if val.Cmp(big.NewInt(maxInt64)) > 0 {
 		return maxInt64

core/os.go

@@ -84,7 +84,7 @@ func downloadDataHTTP(ctx context.Context, uri string) ([]byte, error) {
 	defer resp.Body.Close()
 	if resp.StatusCode != 200 {
 		clog.Errorf(ctx, "Non-200 response for status=%v uri=%s", resp.Status, uri)
-		return nil, fmt.Errorf(resp.Status)
+		return nil, fmt.Errorf("%v", resp.Status)
 	}
 	body, err := common.ReadAtMost(resp.Body, common.MaxSegSize)
 	if err != nil {

core/stream_test.go

@@ -48,22 +48,18 @@ func TestSegmentFlatten(t *testing.T) {
 }
 
 func TestRandomIdGenerator(t *testing.T) {
-	rand.Seed(123)
+	common.PkgRNG = rand.New(rand.NewSource(123))
 	res := common.RandomIDGenerator(DefaultManifestIDLength)
-	if res != "17b336b6" {
-		t.Error("Unexpected RNG result")
-	}
+	assert.Equal(t, "f1405ced", res, "Unexpected RNG result")
 }
 
 func TestStreamID(t *testing.T) {
-	rand.Seed(123)
+	common.PkgRNG = rand.New(rand.NewSource(123))
 	mid := RandomManifestID()
 	profile := ffmpeg.P144p30fps16x9
 
 	// Test random manifest ID generation
-	if string(mid) != "17b336b6" {
-		t.Error("Unexpected ManifestID ", mid)
-	}
+	assert.Equal(t, ManifestID("f1405ced"), mid, "Unexpected ManifestID")
 
 	// Test normal cases
 	id := MakeStreamID(mid, &profile)

discovery/wh_discovery.go

@@ -59,13 +59,14 @@ func (w *webhookPool) getInfos() ([]common.OrchestratorLocalInfo, error) {
 	}
 
 	hash := ethcommon.BytesToHash(crypto.Keccak256(body))
+	w.mu.Lock()
 	if hash == w.responseHash {
-		w.mu.Lock()
 		w.lastRequest = time.Now()
 		pool = w.pool // may have been reset since beginning
 		w.mu.Unlock()
 		return pool.GetInfos(), nil
 	}
+	w.mu.Unlock()
 
 	infos, err := deserializeWebhookJSON(body)
 	if err != nil {

go.mod

@@ -1,6 +1,6 @@
 module github.com/livepeer/go-livepeer
 
-go 1.23.2
+go 1.25.0
 
 require (
 	contrib.go.opencensus.io/exporter/prometheus v0.4.2

server/ai_http.go

@@ -7,6 +7,7 @@ import (
 	"context"
 	"encoding/base64"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"image"
 	"io"
@@ -703,7 +704,7 @@ func (h *lphttp) AIResults() http.Handler {
 				glog.Errorf("Unable to read ai worker error body taskId=%v err=%q", tid, err)
 				workerResult.Err = err
 			} else {
-				workerResult.Err = fmt.Errorf(string(body))
+				workerResult.Err = errors.New(string(body))
 			}
 			glog.Errorf("AI Worker error for taskId=%v err=%q", tid, workerResult.Err)
 			orch.AIResults(tid, &workerResult)