Skip to content

Commit f1748e2

Browse files
authored
fix: re-enable conformance skipping ability (#3651)
# What does this PR do? this was broken by #3631, re-enable this ability by only using oasdiff when .skip != 'true' Signed-off-by: Charlie Doern <[email protected]>
1 parent 7e48cc4 commit f1748e2

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/conformance.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ jobs:
9696
9797
# Verify API specs exist for conformance testing
9898
- name: Check API Specs
99+
if: steps.skip-check.outputs.skip != 'true'
99100
run: |
100101
echo "Checking for API specification files..."
101102
@@ -134,10 +135,10 @@ jobs:
134135
- name: Run OpenAPI Breaking Change Diff
135136
if: steps.skip-check.outputs.skip != 'true'
136137
run: |
137-
oasdiff breaking --fail-on ERR base/docs/static/llama-stack-spec.yaml docs/static/llama-stack-spec.yaml --match-path '^/v1/'
138+
oasdiff breaking --fail-on ERR $BASE_SPEC $CURRENT_SPEC --match-path '^/v1/'
138139
139140
# Report when test is skipped
140141
- name: Report skip reason
141142
if: steps.skip-check.outputs.skip == 'true'
142143
run: |
143-
oasdiff breaking --fail-on ERR $BASE_SPEC $CURRENT_SPEC --match-path '^/v1/'
144+
echo "Conformance test skipped due to breaking change indicator"

0 commit comments

Comments
 (0)