From db6693ec21a994fc21c12d5819dbc21e55db6892 Mon Sep 17 00:00:00 2001 From: sarthakdeshpande Date: Tue, 12 Aug 2025 18:50:31 +0530 Subject: [PATCH 1/3] chore: Added default string to HuggingfacePostTrainingConfig --- .../providers/inline/post_training/huggingface/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llama_stack/providers/inline/post_training/huggingface/config.py b/llama_stack/providers/inline/post_training/huggingface/config.py index 04e286ff09..9b1431e98a 100644 --- a/llama_stack/providers/inline/post_training/huggingface/config.py +++ b/llama_stack/providers/inline/post_training/huggingface/config.py @@ -71,7 +71,7 @@ class HuggingFacePostTrainingConfig(BaseModel): dpo_beta: float = 0.1 use_reference_model: bool = True dpo_loss_type: Literal["sigmoid", "hinge", "ipo", "kto_pair"] = "sigmoid" - dpo_output_dir: str + dpo_output_dir: str = "" @classmethod def sample_run_config(cls, __distro_dir__: str, **kwargs: Any) -> dict[str, Any]: From 771314291e06239c2434af5a911f33359fac40d2 Mon Sep 17 00:00:00 2001 From: sarthakdeshpande Date: Tue, 12 Aug 2025 20:40:04 +0530 Subject: [PATCH 2/3] chore:Updated empty string to None --- .../providers/inline/post_training/huggingface/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llama_stack/providers/inline/post_training/huggingface/config.py b/llama_stack/providers/inline/post_training/huggingface/config.py index 9b1431e98a..d270446199 100644 --- a/llama_stack/providers/inline/post_training/huggingface/config.py +++ b/llama_stack/providers/inline/post_training/huggingface/config.py @@ -71,7 +71,7 @@ class HuggingFacePostTrainingConfig(BaseModel): dpo_beta: float = 0.1 use_reference_model: bool = True dpo_loss_type: Literal["sigmoid", "hinge", "ipo", "kto_pair"] = "sigmoid" - dpo_output_dir: str = "" + dpo_output_dir: str | None = None @classmethod def sample_run_config(cls, __distro_dir__: str, **kwargs: Any) -> dict[str, Any]: From 75bdc7b169d0af137066a219880b6452bb3604f1 Mon Sep 17 00:00:00 2001 From: sarthakdeshpande Date: Tue, 19 Aug 2025 22:46:17 +0530 Subject: [PATCH 3/3] chore:Added a check for if dpo_output_dir exists in config --- .../providers/inline/post_training/huggingface/post_training.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llama_stack/providers/inline/post_training/huggingface/post_training.py b/llama_stack/providers/inline/post_training/huggingface/post_training.py index 22ace1ae03..e0bf63207e 100644 --- a/llama_stack/providers/inline/post_training/huggingface/post_training.py +++ b/llama_stack/providers/inline/post_training/huggingface/post_training.py @@ -135,7 +135,7 @@ async def handler(on_log_message_cb, on_status_change_cb, on_artifact_collected_ resources_allocated, checkpoints = await recipe.train( model=finetuned_model, - output_dir=f"{self.config.dpo_output_dir}/{job_uuid}", + output_dir=f"{self.config.dpo_output_dir}/{job_uuid}" if self.config.dpo_output_dir else None, job_uuid=job_uuid, dpo_config=algorithm_config, config=training_config,