register metrics once

vMaroon · vMaroon · commit 4942be3966c0 · 2025-07-19T02:21:34.000+03:00
Signed-off-by: Maroon Ayoub &lt;maroon.ayoub@ibm.com&gt;
diff --git a/pkg/kvcache/metrics/collector.go b/pkg/kvcache/metrics/collector.go
@@ -2,6 +2,7 @@ package metrics
 
 import (
 	"context"
+	"sync"
 	"time"
 
 	"github.com/prometheus/client_golang/prometheus"
@@ -46,9 +47,13 @@ func Collectors() []prometheus.Collector {
 	}
 }
 
+var registerMetricsOnce = sync.Once{}
+
 // Register registers all metrics with K8s registry.
 func Register() {
-	metrics.Registry.MustRegister(Collectors()...)
+	registerMetricsOnce.Do(func() {
+		metrics.Registry.MustRegister(Collectors()...)
+	})
 }
 
 // StartMetricsLogging spawns a goroutine that logs current metric values every

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package metrics`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
	`5`	`+ "sync"`
`5`	`6`	`"time"`
`6`	`7`
`7`	`8`	`"github.com/prometheus/client_golang/prometheus"`
`@@ -46,9 +47,13 @@ func Collectors() []prometheus.Collector {`
`46`	`47`	`}`
`47`	`48`	`}`
`48`	`49`
	`50`	`+var registerMetricsOnce = sync.Once{}`
	`51`	`+`
`49`	`52`	`// Register registers all metrics with K8s registry.`
`50`	`53`	`func Register() {`
`51`		`- metrics.Registry.MustRegister(Collectors()...)`
	`54`	`+ registerMetricsOnce.Do(func() {`
	`55`	`+ metrics.Registry.MustRegister(Collectors()...)`
	`56`	`+ })`
`52`	`57`	`}`
`53`	`58`
`54`	`59`	`// StartMetricsLogging spawns a goroutine that logs current metric values every`