Address review comments

Author: jpienaar

clang-tools-extra/clang-tidy/llvm/MLIROpBuilderCheck.cpp

@@ -1,5 +1,4 @@
-//===--- MLIROpBuilderCheck.cpp - clang-tidy
-//-------------------------------===//
+//===--- MLIROpBuilderCheck.cpp - clang-tidy ------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -32,23 +31,23 @@ class TypeAsWrittenStencil : public StencilInterface {
 
   llvm::Error eval(const MatchFinder::MatchResult &match,
                    std::string *result) const override {
-    auto n = node(id)(match);
+    RangeSelector n = node(id)(match);
     if (!n)
       return n.takeError();
-    auto srcRange = n->getAsRange();
+    SourceRange srcRange = n->getAsRange();
     if (srcRange.isInvalid()) {
       return llvm::make_error<llvm::StringError>(llvm::errc::invalid_argument,
                                                  "srcRange is invalid");
     }
-    auto range = n->getTokenRange(srcRange);
+    const CharSourceRange range = n->getTokenRange(srcRange);
     auto nextToken = [&](std::optional<Token> token) {
       if (!token)
         return token;
       return clang::Lexer::findNextToken(token->getLocation(),
                                          *match.SourceManager,
                                          match.Context->getLangOpts());
     };
-    auto lessToken = clang::Lexer::findNextToken(
+    std::optional<Token> lessToken = clang::Lexer::findNextToken(
         range.getBegin(), *match.SourceManager, match.Context->getLangOpts());
     while (lessToken && lessToken->getKind() != clang::tok::less) {
       lessToken = nextToken(lessToken);
@@ -58,7 +57,7 @@ class TypeAsWrittenStencil : public StencilInterface {
                                                  "missing '<' token");
     }
     std::optional<Token> endToken = nextToken(lessToken);
-    for (auto greaterToken = nextToken(endToken);
+    for (std::optional<Token> greaterToken = nextToken(endToken);
          greaterToken && greaterToken->getKind() != clang::tok::greater;
          greaterToken = nextToken(greaterToken)) {
       endToken = greaterToken;

clang-tools-extra/docs/ReleaseNotes.rst

@@ -150,6 +150,12 @@ New checks
   Finds unscoped (non-class) ``enum`` declarations and suggests using
   ``enum class`` instead.
 
+- New :doc:`llvm-mlir-op-builder
+  <clang-tidy/checks/llvm/mlir-op-builder>` check.
+
+  Flags usage of old form of invoking create on MLIR's `OpBuilder` and suggests
+  new form.
+
 - New :doc:`llvm-prefer-static-over-anonymous-namespace
   <clang-tidy/checks/llvm/prefer-static-over-anonymous-namespace>` check.
 
@@ -162,11 +168,6 @@ New checks
   Finds uses of ``std::lock_guard`` and suggests replacing them with C++17's
   alternative ``std::scoped_lock``.
 
-- New :doc:`llvm-mlir-op-builder
-  <clang-tidy/checks/llvm/mlir-op-builder>` check.
-
-  Flags usage of old OpBuilder format.
-
 - New :doc:`portability-avoid-pragma-once
   <clang-tidy/checks/portability/avoid-pragma-once>` check.
 

clang-tools-extra/docs/clang-tidy/checks/llvm/mlir-op-builder.rst

@@ -1,9 +1,9 @@
 .. title:: clang-tidy - llvm-mlir-op-builder
 
 llvm-mlir-op-builder
-===============
+====================
 
-Flags usage of old form of invoking create on MLIR's `OpBuilder` and suggesting
+Flags usage of old form of invoking create on MLIR's `OpBuilder` and suggests
 new form.
 
 Example
@@ -19,4 +19,3 @@ Transforms to:
 .. code-block:: c++
 
   FooOp::create(builder, builder.getUnknownLoc(), "baz");
-