Regression clang-formatting __declspec(uuid(...))

[nico]

Current HEAD (3322ba4):

% out/gn/bin/clang-format declspec-uuid.cc                                  
template <>
struct __declspec(uuid(
    "3895C200-8F26-4F5A-B29D-2B5D72E68F99")) IAsyncOperation<IUnknown *>
    : IAsyncOperation_impl<IUnknown *> {};

Back at 1066481 (Oct 2023, a while ago):

% ~/src/chrome/src/buildtools/mac_arm64/format/clang-format declspec-uuid.cc
template <>
struct __declspec(uuid("3895C200-8F26-4F5A-B29D-2B5D72E68F99"))
IAsyncOperation<IUnknown *> : IAsyncOperation_impl<IUnknown *> {};

The old formatting is more correct.

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Nico Weber (nico)

Current HEAD (3322ba4):

% out/gn/bin/clang-format declspec-uuid.cc                                  
template <>
struct __declspec(uuid(
    "3895C200-8F26-4F5A-B29D-2B5D72E68F99")) IAsyncOperation<IUnknown *>
    : IAsyncOperation_impl<IUnknown *> {};

Back at 1066481 (Oct 2023, a while ago):

% ~/src/chrome/src/buildtools/mac_arm64/format/clang-format declspec-uuid.cc
template <>
struct __declspec(uuid("3895C200-8F26-4F5A-B29D-2B5D72E68F99"))
IAsyncOperation<IUnknown *> : IAsyncOperation_impl<IUnknown *> {};

The old formatting is more correct.

[nico]

Bisects to a852869.

[owenca]

cc @gedare

[gedare]

AnnotatedTokens(L=0, P=0, T=6, C=0):
 M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=template L=8 PPK=2 FakeLParens= FakeRParens=0 II=0x2910d98 Text='template'
 M=0 C=0 T=TemplateOpener S=1 F=0 B=0 BK=0 P=30 Name=less L=10 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='<'
 M=0 C=0 T=TemplateCloser S=0 F=0 B=0 BK=0 P=360 Name=greater L=11 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='>'
 M=0 C=1 T=Unknown S=1 F=0 B=0 BK=0 P=30 Name=struct L=18 PPK=2 FakeLParens= FakeRParens=0 II=0x2910560 Text='struct'
 M=0 C=1 T=Unknown S=1 F=0 B=0 BK=0 P=5020 Name=__declspec L=29 PPK=2 FakeLParens= FakeRParens=0 II=0x2915f10 Text='__declspec'
 M=0 C=0 T=AttributeLParen S=0 F=0 B=0 BK=0 P=23 Name=l_paren L=30 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='('
 M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=59 Name=identifier L=34 PPK=2 FakeLParens= FakeRParens=0 II=0x295ac90 Text='uuid'
 M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=43 Name=l_paren L=35 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='('
 M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=43 Name=l_paren L=35 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='('
 M=0 C=1 T=Unknown S=0 F=0 B=0 BK=0 P=79 Name=string_literal L=73 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='"3895C200-8F26-4F5A-B29D-2B5D72E68F99"'
 M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=63 Name=r_paren L=74 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=')'
 M=0 C=0 T=AttributeRParen S=0 F=0 B=0 BK=0 P=43 Name=r_paren L=75 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=')'
M=0 C=1 T=StartOfName S=1 F=0 B=0 BK=0 P=220 Name=identifier L=91 PPK=2 FakeLParens= FakeRParens=0 II=0x295acc8 Text='IAsyncOperation'

This is picking up the IAsyncOperation as the start of a name, so it gets the ContinuationIndent. Fix posted.