Avoid critical-then-exception logs.

While Logger.exception is a handy way of printing stack traces, any log
message can include them. Include the stack trace as part of critical
logs instead of in a separate message.

Author: kfindeisen

python/activator/driver_gunicorn.py

@@ -99,9 +99,8 @@ def create_app():
         app.register_error_handler(500, server_error)
         _log.info("Worker ready to handle requests.")
         return app
-    except Exception as e:
-        _log.critical("Failed to start worker; aborting.")
-        _log.exception(e)
+    except Exception:
+        _log.critical("Failed to start worker; aborting.", exc_info=True)
         # gunicorn assumes exit code 3 means "Worker failed to boot", though this is not documented
         sys.exit(3)
 

python/activator/driver_keda.py

@@ -297,9 +297,8 @@ def keda_start():
 
         _log.info("Worker ready to handle requests.")
 
-    except Exception as e:
-        _log.critical("Failed to start worker; aborting.")
-        _log.exception(e)
+    except Exception:
+        _log.critical("Failed to start worker; aborting.", exc_info=True)
         sys.exit(1)
 
     fan_out_listen_start_time = time.time()
@@ -336,9 +335,8 @@ def keda_start():
                         _log.debug("Seconds since fan out message delivered %r", fan_out_to_prompt_time)
 
                     # TODO Review Redis Errors and determine what should be retriable.
-                    except redis.exceptions.RedisError as e:
-                        _log.critical("Redis Streams error; aborting.")
-                        _log.exception(e)
+                    except redis.exceptions.RedisError:
+                        _log.critical("Redis Streams error; aborting.", exc_info=True)
                         sys.exit(1)
                     except ValueError as e:
                         _log.error("Invalid redis stream message %s", e)