AC-11662 CSP - improve script rendering

tranthienbinh1989 · tranthienbinh1989 · commit 78fab80dbc91 · 2024-03-26T13:07:38.000-05:00
diff --git a/app/code/Magento/PageBuilder/view/base/templates/googlemaps.phtml b/app/code/Magento/PageBuilder/view/base/templates/googlemaps.phtml
@@ -35,7 +35,7 @@ $script = <<<SCRIPT
         }
     });
 SCRIPT;
-
+// phpcs:ignore
 echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);
 
 /** Include the googleMaps dependency only if we have an API key set, this removes unnecessary calls to Google */
@@ -51,5 +51,6 @@ if ($block->shouldIncludeGoogleMapsLibrary()) {
     });
 SCRIPT;
 
+    // phpcs:ignore
     echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);
 }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ $script = <<<SCRIPT`
`35`	`35`	`}`
`36`	`36`	`});`
`37`	`37`	`SCRIPT;`
`38`		`-`
	`38`	`+// phpcs:ignore`
`39`	`39`	`echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);`
`40`	`40`
`41`	`41`	`/** Include the googleMaps dependency only if we have an API key set, this removes unnecessary calls to Google */`
`@@ -51,5 +51,6 @@ if ($block->shouldIncludeGoogleMapsLibrary()) {`
`51`	`51`	`});`
`52`	`52`	`SCRIPT;`
`53`	`53`
	`54`	`+ // phpcs:ignore`
`54`	`55`	`echo /* @noEscape */ $secureRenderer->renderTag('script', [], $script, false);`
`55`	`56`	`}`