Skip to content

Commit 74c3dcf

Browse files
committed
fix coroutine tests
1 parent 5f10fcb commit 74c3dcf

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

libnavigation-core/api/current.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,7 @@ package com.mapbox.navigation.core.trip {
10501050
}
10511051

10521052
public final class MapboxTripStarterKt {
1053-
method @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public static void update(com.mapbox.navigation.core.trip.MapboxTripStarter, kotlin.jvm.functions.Function1<? super com.mapbox.navigation.core.trip.MapboxTripStarterOptions.Builder,com.mapbox.navigation.core.trip.MapboxTripStarterOptions.Builder> function);
1053+
method @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public static com.mapbox.navigation.core.trip.MapboxTripStarter update(com.mapbox.navigation.core.trip.MapboxTripStarter, kotlin.jvm.functions.Function1<? super com.mapbox.navigation.core.trip.MapboxTripStarterOptions.Builder,com.mapbox.navigation.core.trip.MapboxTripStarterOptions.Builder> function);
10541054
}
10551055

10561056
@com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public final class MapboxTripStarterOptions {

libnavigation-core/src/test/java/com/mapbox/navigation/core/trip/MapboxTripStarterTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ class MapboxTripStarterTest {
7474
sut.onAttached(mapboxNavigation)
7575
every { PermissionsManager.areLocationPermissionsGranted(any()) } returns true
7676
sut.setLocationPermissionGranted(true)
77+
testCoroutineScope.cleanupTestCoroutines()
7778

7879
verify(exactly = 1) { mapboxNavigation.startTripSession() }
7980
}
@@ -84,13 +85,10 @@ class MapboxTripStarterTest {
8485

8586
val mapboxNavigation = mockMapboxNavigation()
8687
sut.onAttached(mapboxNavigation)
87-
sut.setLocationPermissionGranted(true)
8888

89-
// Clean up coroutines early so that the error is caught by the tests.
9089
assertThrows(Exception::class.java) {
91-
coroutineRule.createdScopes.forEach { it.cleanupTestCoroutines() }
90+
sut.setLocationPermissionGranted(true)
9291
}
93-
coroutineRule.createdScopes.clear()
9492
}
9593

9694
@Test
@@ -110,9 +108,10 @@ class MapboxTripStarterTest {
110108

111109
val mapboxNavigation = mockMapboxNavigation()
112110
sut.onAttached(mapboxNavigation)
113-
sut.update { it.tripType(MapboxTripStarterExtra.MAPBOX_TRIP_STARTER_REPLAY_ROUTE) }
114111
every { PermissionsManager.areLocationPermissionsGranted(any()) } returns true
115112
sut.setLocationPermissionGranted(true)
113+
sut.update { it.tripType(MapboxTripStarterExtra.MAPBOX_TRIP_STARTER_REPLAY_ROUTE) }
114+
testCoroutineScope.cleanupTestCoroutines()
116115

117116
verify(exactly = 1) { mapboxNavigation.startReplayTripSession() }
118117
}
@@ -125,6 +124,7 @@ class MapboxTripStarterTest {
125124

126125
sut.onAttached(mapboxNavigation)
127126
sut.update { it.tripType(MapboxTripStarterExtra.MAPBOX_TRIP_STARTER_REPLAY_ROUTE) }
127+
testCoroutineScope.cleanupTestCoroutines()
128128

129129
verify(exactly = 0) { mapboxNavigation.stopTripSession() }
130130
verify(exactly = 1) { mapboxNavigation.startReplayTripSession() }

0 commit comments

Comments
 (0)