linting fixes

Author: markus-wa

pkg/demoinfocs/common/common.go

@@ -96,7 +96,7 @@ func (g *GrenadeProjectile) UniqueID() int64 {
 //
 // Intended for internal use only.
 func NewGrenadeProjectile() *GrenadeProjectile {
-	return &GrenadeProjectile{uniqueID: rand.Int63()}
+	return &GrenadeProjectile{uniqueID: rand.Int63()} //nolint:gosec
 }
 
 // Bomb tracks the bomb's position, and the player carrying it, if any.

pkg/demoinfocs/common/equipment.go

@@ -375,7 +375,7 @@ func (e *Equipment) AmmoReserve() int {
 //
 // Intended for internal use only.
 func NewEquipment(wep EquipmentType) *Equipment {
-	return &Equipment{Type: wep, uniqueID: rand.Int63()}
+	return &Equipment{Type: wep, uniqueID: rand.Int63()} //nolint:gosec
 }
 
 var equipmentToAlternative = map[EquipmentType]EquipmentType{

pkg/demoinfocs/common/inferno.go

@@ -189,7 +189,7 @@ func convexHull(pointCloud []r3.Vector) quickhull.ConvexHull {
 func NewInferno(demoInfoProvider demoInfoProvider, entity st.Entity) *Inferno {
 	return &Inferno{
 		Entity:           entity,
-		uniqueID:         rand.Int63(),
+		uniqueID:         rand.Int63(), //nolint:gosec
 		demoInfoProvider: demoInfoProvider,
 	}
 }

pkg/demoinfocs/debug_on.go

@@ -43,7 +43,7 @@ func debugGameEvent(d *msg.CSVCMsg_GameEventListDescriptorT, ge *msg.CSVCMsg_Gam
 		data := make(map[string]any)
 
 		for k, v := range mapGameEventData(d, ge) {
-			switch v.Type {
+			switch v.GetType() {
 			case typeStr:
 				data[k] = v.ValString
 			case typeFloat:

pkg/demoinfocs/demoinfocs_test.go

@@ -202,6 +202,7 @@ func TestEncryptedNetMessages(t *testing.T) {
 	}
 
 	infoF, err := os.Open(csDemosPath + "/match730_003528806449641685104_1453182610_271.dem.info")
+	assert.NoError(t, err)
 
 	b, err := ioutil.ReadAll(infoF)
 	assert.NoError(t, err)

pkg/demoinfocs/net_messages.go

@@ -34,7 +34,7 @@ func (p *parser) handlePacketEntities(pe *msg.CSVCMsg_PacketEntities) {
 				}
 
 				p.gameState.entities[currentEntity] = p.stParser.ReadEnterPVS(r, currentEntity)
-			} else { //nolint:gocritic
+			} else {
 				// Delta Update
 				if entity := p.gameState.entities[currentEntity]; entity != nil {
 					entity.ApplyUpdate(r)
@@ -141,6 +141,7 @@ func (p *parser) handleEncryptedData(msg *msg.CSVCMsg_EncryptedData) {
 	}
 
 	msgB := br.ReadBytes(int(size))
+
 	err := proto.Unmarshal(msgB, m)
 	if err != nil {
 		p.setError(err)

pkg/demoinfocs/parsing.go

@@ -327,7 +327,6 @@ func (p *parser) netMessageForCmd(cmd int) proto.Message {
 	return nil
 }
 
-//nolint:funlen
 func (p *parser) parsePacket() {
 	// Booooring
 	// 152 bytes CommandInfo, 4 bytes SeqNrIn, 4 bytes SeqNrOut

pkg/demoinfocs/sendtables/st_parser.go

@@ -168,10 +168,9 @@ func (p *SendTableParser) flattenDataTable(serverClassIndex int) {
 				prop := fProps[cp].prop
 				if prop.priority == prio || (prio == 64 && prop.flags.hasFlagSet(propFlagChangesOften)) {
 					if start != cp {
-						tmp := fProps[start]
-						fProps[start] = fProps[cp]
-						fProps[cp] = tmp
+						fProps[start], fProps[cp] = fProps[cp], fProps[start]
 					}
+
 					start++
 
 					break

pkg/demoinfocs/stringtables.go

@@ -86,15 +86,15 @@ func (p *parser) parseSingleStringTable(name string) {
 					panic(errors.Wrap(err, "couldn't parse playerIndex from string"))
 				}
 
-				p.setRawPlayer(int(playerIndex), player)
+				p.setRawPlayer(playerIndex, player)
 
 			case stNameInstanceBaseline:
 				classID, err := strconv.Atoi(stringName)
 				if err != nil {
 					panic(errors.Wrap(err, "couldn't parse serverClassID from string"))
 				}
 
-				p.stParser.SetInstanceBaseline(int(classID), data)
+				p.stParser.SetInstanceBaseline(classID, data)
 
 			case stNameModelPreCache:
 				p.modelPreCache = append(p.modelPreCache, stringName)

pkg/demoinfocs/user_messages.go

@@ -135,6 +135,7 @@ func (umh userMessageHandler) rankUpdate(um *msg.CSVCMsg_UserMessage) {
 	for _, v := range st.RankUpdate {
 		// find player (or old instance if he has disconnected already)
 		steamID32 := uint32(v.GetAccountId())
+
 		player, ok := umh.parser.gameState.playersBySteamID32[steamID32]
 		if !ok {
 			errMsg := fmt.Sprintf("rank update for unknown player with SteamID32=%d", steamID32)