Skip to content

Commit fd43c54

Browse files
author
Pavel Kardash
committed
Handle all m.room.aliases chunk, not only last
1 parent fdcd726 commit fd43c54

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

matrix_client/room.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -454,17 +454,20 @@ def update_aliases(self):
454454
Returns:
455455
boolean: True if the aliases changed, False if not
456456
"""
457+
response = None
457458
try:
458459
response = self.client.api.get_room_state(self.room_id)
459-
for chunk in response:
460-
if "content" in chunk and "aliases" in chunk["content"]:
461-
if chunk["content"]["aliases"] != self.aliases:
462-
self.aliases = chunk["content"]["aliases"]
463-
return True
464-
else:
465-
return False
466460
except MatrixRequestError:
467461
return False
462+
self.aliases = []
463+
changed = False
464+
for chunk in response:
465+
if "content" in chunk and "aliases" in chunk["content"]:
466+
for alias in chunk["content"]["aliases"]:
467+
if alias not in self.aliases:
468+
self.aliases.append(alias)
469+
changed = True
470+
return changed
468471

469472
def add_room_alias(self, room_alias):
470473
"""Add an alias to the room and return True if successful."""

0 commit comments

Comments
 (0)