Skip to content

Commit 016d509

Browse files
authored
Merge pull request #76 from matrix-org/ci/fix-ndk-path
Fix the `NDK_PATH` value
1 parent 907438f commit 016d509

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

.github/workflows/release_crypto.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ jobs:
4747
java-version: '17'
4848
distribution: 'temurin' # See 'Supported distributions' for available options
4949

50-
- name: Install android sdk
51-
uses: malinskiy/action-android/install-sdk@release/0.1.4
52-
50+
# Note: the install android SDK step resets the `ANDROID_HOME` variable to a new folder with an update SDK but no NDK,
51+
# so we need to set this NDK_PATH before that happens
5352
- name: Configure android ndk
5453
run: |
5554
NDK_PATH=$ANDROID_HOME/ndk/$NDK_VERSION
55+
echo $NDK_PATH
5656
if [ -d "$NDK_PATH" ]; then
5757
echo "ANDROID_NDK_HOME=$NDK_PATH" >> $GITHUB_ENV
5858
echo "Using ndk $NDK_PATH"
@@ -61,6 +61,9 @@ jobs:
6161
exit 1
6262
fi
6363
64+
- name: Install android sdk
65+
uses: malinskiy/action-android/install-sdk@release/0.1.4
66+
6467
- name: Install Rust
6568
uses: dtolnay/rust-toolchain@stable
6669

.github/workflows/release_sdk_parallel.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ jobs:
4747
java-version: '17'
4848
distribution: 'temurin' # See 'Supported distributions' for available options
4949

50-
- name: Install android sdk
51-
uses: malinskiy/action-android/install-sdk@release/0.1.4
52-
50+
# Note: the install android SDK step resets the `ANDROID_HOME` variable to a new folder with an update SDK but no NDK,
51+
# so we need to set this NDK_PATH before that happens
5352
- name: Configure android ndk
5453
run: |
5554
NDK_PATH=$ANDROID_HOME/ndk/$NDK_VERSION
55+
echo $NDK_PATH
5656
if [ -d "$NDK_PATH" ]; then
5757
echo "ANDROID_NDK_HOME=$NDK_PATH" >> $GITHUB_ENV
5858
echo "Using ndk $NDK_PATH"
@@ -61,6 +61,9 @@ jobs:
6161
exit 1
6262
fi
6363
64+
- name: Install android sdk
65+
uses: malinskiy/action-android/install-sdk@release/0.1.4
66+
6467
- name: Install Rust
6568
uses: dtolnay/rust-toolchain@stable
6669

0 commit comments

Comments
 (0)