fix sca and free clone

Author: gouhongshen

pkg/common/moerr/error.go

@@ -20,7 +20,6 @@ import (
 	"encoding/hex"
 	"fmt"
 	"io"
-	"strings"
 	"sync/atomic"
 
 	moerrpb "github.com/matrixorigin/matrixone/pkg/pb/moerr"
@@ -1021,10 +1020,6 @@ func NewNotLeaseHolder(ctx context.Context, holderId uint64) *Error {
 }
 
 func NewNoSuchTable(ctx context.Context, db, tbl string) *Error {
-	if strings.Contains(tbl, "index") {
-		x := 0
-		x++
-	}
 	return newError(ctx, ErrNoSuchTable, db, tbl)
 }
 

pkg/sql/compile/alter.go

@@ -17,6 +17,7 @@ package compile
 import (
 	"context"
 	"fmt"
+	"github.com/matrixorigin/matrixone/pkg/common/reuse"
 	"github.com/matrixorigin/matrixone/pkg/sql/colexec/table_clone"
 	"slices"
 
@@ -579,6 +580,7 @@ func cowUnaffectedIndexes(
 	releaseClone := func() {
 		if clone != nil {
 			clone.Free(c.proc, false, err)
+			reuse.Free[table_clone.TableClone](clone, nil)
 			clone = nil
 		}
 	}

pkg/sql/compile/compile.go

@@ -402,12 +402,7 @@ func (c *Compile) run(s *Scope) error {
 	case AlterView:
 		return s.AlterView(c)
 	case AlterTable:
-		err := s.AlterTable(c)
-		if err != nil {
-			x := 0
-			x++
-		}
-		return err
+		return s.AlterTable(c)
 	case RenameTable:
 		return s.RenameTable(c)
 	case DropTable:

pkg/sql/plan/build_table_clone.go

@@ -35,15 +35,9 @@ func buildCloneTable(
 ) (*Plan, error) {
 
 	var (
-		err error
-
-		//id int32
-
+		err       error
 		srcTblDef *TableDef
-
-		srcObj *ObjectRef
-
-		//query *Query
+		srcObj    *ObjectRef
 
 		createTablePlan *Plan
 
@@ -103,32 +97,11 @@ func buildCloneTable(
 
 	dstTableName = stmt.CreateTable.Table.ObjectName.String()
 	dstDatabaseName = stmt.CreateTable.Table.SchemaName.String()
-	//dstTblDef := DeepCopyTableDef(srcTblDef, true)
-	//dstTblDef.Name = stmt.CreateTable.Table.ObjectName.String()
-	//dstTblDef.DbName = stmt.CreateTable.Table.SchemaName.String()
 
 	if dstDatabaseName == "" {
 		dstDatabaseName = ctx.DefaultDatabase()
 	}
 
-	//node := &plan.Node{
-	//	ObjRef:       srcObj,
-	//	NodeType:     plan.Node_TABLE_CLONE,
-	//	TableDef:     srcTblDef,
-	//	ScanSnapshot: bindCtx.snapshot,
-	//	//InsertCtx: &plan.InsertCtx{
-	//	//	TableDef: dstTblDef,
-	//	//},
-	//	BindingTags: []int32{builder.genNewTag()},
-	//	Stats: &plan.Stats{
-	//		ForceOneCN: true,
-	//	},
-	//}
-
-	//builder.qry.Steps = append(builder.qry.Steps, id)
-	//builder.qry.Nodes[0].Stats.ForceOneCN = true
-	//builder.skipStats = true
-
 	var (
 		opAccount  uint32
 		dstAccount uint32
@@ -167,13 +140,6 @@ func buildCloneTable(
 		return nil, err
 	}
 
-	//if query, err = builder.createQuery(); err != nil {
-	//	return nil, err
-	//}
-
-	//createTablePlan.Plan.(*plan.Plan_Ddl).Ddl.Query = query
-	//createTablePlan.Plan.(*plan.Plan_Ddl).Ddl.DdlType = plan.DataDefinition_CREATE_TABLE_WITH_CLONE
-
 	return &Plan{
 		Plan: &plan.Plan_Ddl{
 			Ddl: &plan.DataDefinition{
@@ -191,8 +157,6 @@ func buildCloneTable(
 			},
 		},
 	}, nil
-
-	//return createTablePlan, nil
 }
 
 func checkPrivilege(