fix: respect TOOL_NAME_PREFIX env var in tool name generation

Author: matthewhand

mcp_openapi_proxy/utils.py

@@ -55,8 +55,13 @@ def normalize_tool_name(raw_name: str, max_length: Optional[int] = None) -> str:
         # Remove repeated underscores
         tool_name = re.sub(r"_+", "_", tool_name)
 
+        # Apply TOOL_NAME_PREFIX if set
+        tool_name_prefix = os.getenv("TOOL_NAME_PREFIX", "")
+        if tool_name_prefix:
+            tool_name = f"{tool_name_prefix}{tool_name}"
+
         if effective_max_length is not None and effective_max_length > 0:
-            tool_name = tool_name[:max_length]
+            tool_name = tool_name[:effective_max_length]
 
         return tool_name
     except Exception:

tests/unit/test_utils.py

@@ -96,3 +96,19 @@ def test_strip_parameters_no_param():
     params = {"channel": "test"}
     result = strip_parameters(params)
     assert result == {"channel": "test"}
+
+def test_tool_name_prefix(monkeypatch):
+    """Test that TOOL_NAME_PREFIX env var is respected when generating tool names."""
+    import os
+    from mcp_openapi_proxy.utils import normalize_tool_name
+
+    # Set prefix in environment
+    monkeypatch.setenv("TOOL_NAME_PREFIX", "otrs_")
+
+    # Use correct raw_name format: "METHOD /path"
+    raw_name = "GET /users/list"
+    tool_name = normalize_tool_name(raw_name)
+    prefix = os.getenv("TOOL_NAME_PREFIX", "")
+    assert tool_name.startswith(prefix), f"Tool name '{tool_name}' does not start with prefix '{prefix}'"
+    # Also check the rest of the name
+    assert tool_name == "otrs_get_users_list"