Skip to content

Doctests fail on some architectures (i686, s390x) #3

@blinxen

Description

@blinxen

I am packaging byteyarn for Fedora because it is a dependency of gitoxide. When running doctests on i686 and s390x machines, most doctests fail. See:

There are assertion fails:

assertion `left == right` failed
  left: 3242591731706757321
 right: 9

But more importantly there are tests that just straight up crash with a Test executable failed (signal: 11 (SIGSEGV) (core dumped)).

Looking at the code (e.g. this function), it appears that the you assume the byte order. This however cannot work if the byte order is reversed (little endian vs big endian).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions