Remove useless requirement (#302)

* Remove useless requirement

* Change activation type on reacher config

* docs: add sehyun-hwang as a contributor (#303)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Update ray version

* Fix typo

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

Author: MrSyee

.all-contributorsrc

@@ -76,6 +76,15 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "sehyun-hwang",
+      "name": "Sehyun Hwang",
+      "avatar_url": "https://avatars3.githubusercontent.com/u/23437715?v=4",
+      "profile": "https://github.com/sehyun-hwang",
+      "contributions": [
+        "maintenance"
+      ]
     }
   ],
   "contributorsPerLine": 7,

README.md

@@ -4,7 +4,7 @@
 [![Language grade: Python](https://img.shields.io/lgtm/grade/python/g/medipixel/rl_algorithms.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/medipixel/rl_algorithms/context:python)
 [![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](https://opensource.org/licenses/MIT)
 [![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[![All Contributors](https://img.shields.io/badge/all_contributors-8-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-9-orange.svg?style=flat-square)](#contributors-)
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 
 </p>
@@ -36,21 +36,23 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
 <!-- markdownlint-disable -->
 <table>
   <tr>
-    <td align="center"><a href="https://github.com/Curt-Park"><img src="https://avatars3.githubusercontent.com/u/14961526?v=4" width="100px;" alt=""/><br /><sub><b>Jinwoo Park (Curt)</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=Curt-Park" title="Code">💻</a></td>
-    <td align="center"><a href="https://github.com/MrSyee"><img src="https://avatars3.githubusercontent.com/u/17582508?v=4" width="100px;" alt=""/><br /><sub><b>Kyunghwan Kim</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=MrSyee" title="Code">💻</a></td>
-    <td align="center"><a href="https://github.com/darthegg"><img src="https://avatars3.githubusercontent.com/u/16010242?v=4" width="100px;" alt=""/><br /><sub><b>darthegg</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=darthegg" title="Code">💻</a></td>
-    <td align="center"><a href="https://github.com/mclearning2"><img src="https://avatars3.githubusercontent.com/u/43226417?v=4" width="100px;" alt=""/><br /><sub><b>Mincheol Kim</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=mclearning2" title="Code">💻</a></td>
-    <td align="center"><a href="https://github.com/minseop4898"><img src="https://avatars1.githubusercontent.com/u/34338299?v=4" width="100px;" alt=""/><br /><sub><b>김민섭</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=minseop4898" title="Code">💻</a></td>
-    <td align="center"><a href="https://github.com/jinPrelude"><img src="https://avatars1.githubusercontent.com/u/16518993?v=4" width="100px;" alt=""/><br /><sub><b>Leejin Jung</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=jinPrelude" title="Code">💻</a></td>
-    <td align="center"><a href="https://github.com/cyoon1729"><img src="https://avatars2.githubusercontent.com/u/33583101?v=4" width="100px;" alt=""/><br /><sub><b>Chris Yoon</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=cyoon1729" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/Curt-Park"><img src="https://avatars3.githubusercontent.com/u/14961526?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Jinwoo Park (Curt)</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=Curt-Park" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/MrSyee"><img src="https://avatars3.githubusercontent.com/u/17582508?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Kyunghwan Kim</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=MrSyee" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/darthegg"><img src="https://avatars3.githubusercontent.com/u/16010242?v=4?s=100" width="100px;" alt=""/><br /><sub><b>darthegg</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=darthegg" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/mclearning2"><img src="https://avatars3.githubusercontent.com/u/43226417?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Mincheol Kim</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=mclearning2" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/minseop4898"><img src="https://avatars1.githubusercontent.com/u/34338299?v=4?s=100" width="100px;" alt=""/><br /><sub><b>김민섭</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=minseop4898" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/jinPrelude"><img src="https://avatars1.githubusercontent.com/u/16518993?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Leejin Jung</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=jinPrelude" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/cyoon1729"><img src="https://avatars2.githubusercontent.com/u/33583101?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Chris Yoon</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=cyoon1729" title="Code">💻</a></td>
   </tr>
   <tr>
-    <td align="center"><a href="https://jiseonghan.github.io/"><img src="https://avatars2.githubusercontent.com/u/48741026?v=4" width="100px;" alt=""/><br /><sub><b>Jiseong Han</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=jiseongHAN" title="Code">💻</a></td>
+    <td align="center"><a href="https://jiseonghan.github.io/"><img src="https://avatars2.githubusercontent.com/u/48741026?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Jiseong Han</b></sub></a><br /><a href="https://github.com/medipixel/rl_algorithms/commits?author=jiseongHAN" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/sehyun-hwang"><img src="https://avatars3.githubusercontent.com/u/23437715?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Sehyun Hwang</b></sub></a><br /><a href="#maintenance-sehyun-hwang" title="Maintenance">🚧</a></td>
   </tr>
 </table>
 
-<!-- markdownlint-enable -->
+<!-- markdownlint-restore -->
 <!-- prettier-ignore-end -->
+
 <!-- ALL-CONTRIBUTORS-LIST:END -->
 This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification.
 

configs/reacher_v2/bc_ddpg.py

@@ -3,9 +3,6 @@
 - Author: Kyunghwan Kim
 - Contact: [email protected]
 """
-import torch
-
-from rl_algorithms.common.helper_functions import identity
 
 agent = dict(
     type="BCDDPGAgent",
@@ -34,12 +31,14 @@
         head=dict(
             actor=dict(
                 type="MLP",
-                configs=dict(hidden_sizes=[256, 256], output_activation=torch.tanh,),
+                configs=dict(hidden_sizes=[256, 256], output_activation="tanh",),
             ),
             critic=dict(
                 type="MLP",
                 configs=dict(
-                    hidden_sizes=[256, 256], output_size=1, output_activation=identity,
+                    hidden_sizes=[256, 256],
+                    output_size=1,
+                    output_activation="identity",
                 ),
             ),
         ),

configs/reacher_v2/bc_sac.py

@@ -3,7 +3,6 @@
 - Author: Kyunghwan Kim
 - Contact: [email protected]
 """
-from rl_algorithms.common.helper_functions import identity
 
 agent = dict(
     type="BCSACAgent",
@@ -36,18 +35,22 @@
         head=dict(
             actor=dict(
                 type="TanhGaussianDistParams",
-                configs=dict(hidden_sizes=[256, 256], output_activation=identity,),
+                configs=dict(hidden_sizes=[256, 256], output_activation="identity",),
             ),
             critic_vf=dict(
                 type="MLP",
                 configs=dict(
-                    hidden_sizes=[256, 256], output_activation=identity, output_size=1,
+                    hidden_sizes=[256, 256],
+                    output_activation="identity",
+                    output_size=1,
                 ),
             ),
             critic_qf=dict(
                 type="MLP",
                 configs=dict(
-                    hidden_sizes=[256, 256], output_activation=identity, output_size=1,
+                    hidden_sizes=[256, 256],
+                    output_activation="identity",
+                    output_size=1,
                 ),
             ),
         ),

configs/reacher_v2/ddpg.py

@@ -3,9 +3,6 @@
 - Author: Kyunghwan Kim
 - Contact: [email protected]
 """
-import torch
-
-from rl_algorithms.common.helper_functions import identity
 
 agent = dict(
     type="DDPGAgent",
@@ -25,12 +22,14 @@
         head=dict(
             actor=dict(
                 type="MLP",
-                configs=dict(hidden_sizes=[256, 256], output_activation=torch.tanh,),
+                configs=dict(hidden_sizes=[256, 256], output_activation="tanh",),
             ),
             critic=dict(
                 type="MLP",
                 configs=dict(
-                    hidden_sizes=[256, 256], output_size=1, output_activation=identity,
+                    hidden_sizes=[256, 256],
+                    output_size=1,
+                    output_activation="identity",
                 ),
             ),
         ),

configs/reacher_v2/sac.py

@@ -3,7 +3,6 @@
 - Author: Kyunghwan Kim
 - Contact: [email protected]
 """
-from rl_algorithms.common.helper_functions import identity
 
 agent = dict(
     type="SACAgent",
@@ -27,18 +26,22 @@
         head=dict(
             actor=dict(
                 type="TanhGaussianDistParams",
-                configs=dict(hidden_sizes=[256, 256], output_activation=identity,),
+                configs=dict(hidden_sizes=[256, 256], output_activation="identity",),
             ),
             critic_vf=dict(
                 type="MLP",
                 configs=dict(
-                    hidden_sizes=[256, 256], output_activation=identity, output_size=1,
+                    hidden_sizes=[256, 256],
+                    output_activation="identity",
+                    output_size=1,
                 ),
             ),
             critic_qf=dict(
                 type="MLP",
                 configs=dict(
-                    hidden_sizes=[256, 256], output_activation=identity, output_size=1,
+                    hidden_sizes=[256, 256],
+                    output_activation="identity",
+                    output_size=1,
                 ),
             ),
         ),

configs/reacher_v2/td3.py

@@ -3,9 +3,6 @@
 - Author: Kyunghwan Kim
 - Contact: [email protected]
 """
-import torch
-
-from rl_algorithms.common.helper_functions import identity
 
 agent = dict(
     type="TD3Agent",
@@ -23,12 +20,14 @@
         head=dict(
             actor=dict(
                 type="MLP",
-                configs=dict(hidden_sizes=[400, 300], output_activation=torch.tanh,),
+                configs=dict(hidden_sizes=[400, 300], output_activation="tanh",),
             ),
             critic=dict(
                 type="MLP",
                 configs=dict(
-                    hidden_sizes=[400, 300], output_size=1, output_activation=identity,
+                    hidden_sizes=[400, 300],
+                    output_size=1,
+                    output_activation="identity",
                 ),
             ),
         ),

requirements.txt

@@ -1,22 +1,21 @@
-numpy == 1.18.0
-torch == 1.6.0
-gym == 0.17.3
-atari-py == 0.2.6
-box2d-py == 2.3.8
-scipy == 1.5.4
-opencv-python == 4.4.0.46
-addict == 2.4.0
+numpy==1.18.0
+torch==1.6.0
+gym==0.17.3
+atari-py==0.2.6
+box2d-py==2.3.8
+scipy==1.5.4
+opencv-python==4.4.0.46
+addict==2.4.0
 tqdm
 
 # for distributed learning
-redis == 3.3.2  # for ray
-ray == 1.0.1.post1
-chardet == 3.0.4
-pyzmq == 20.0.0
-pyarrow == 2.0.0
+redis==3.5.3  # for ray
+ray==1.1.0
+pyzmq==20.0.0
+pyarrow==2.0.0
 
 # for log
-six >= 1.13.0
-wandb == 0.10.11
-matplotlib == 3.3.3
-plotly == 4.13.0
+six>=1.13.0
+wandb==0.10.11
+matplotlib==3.3.3
+plotly==4.13.0

tools/check_version.sh

@@ -14,4 +14,4 @@ if [ "$VERSION" = "$TAG" ]; then
 else
     echo "Tag and version are not same. Check again."
     exit 1
-fi;
+fi;