After applying a saved filter using the chip, again clicking the same does not unselect the filter

[ymaheshwari1]

Steps to reproduce:

• Go to a page where we have a saved filter (like the order page)
• Select a saved filter
• Click the same filter again, but it does not unselect the filter

Screenshot:

[olivermrbl]

Thanks for reporting it in! Issue has been included in our backlog :)

[pKorsholm]

Just some context for where this issue arises and should be solved. In the order-filter-dropdown/index.tsx an eventhandler (handleTabClick) is responsible alerting the filter context of a change in tabs. If the tabname passed along is the active tab we should deselect rather than re-apply. wdyt @olivermrbl?

Please drop a comment if you want to work on this 😄

[ymaheshwari1]

Just some context for where this issue arises and should be solved. In the order-filter-dropdown/index.tsx an eventhandler (handleTabClick) is responsible alerting the filter context of a change in tabs. If the tabname passed along is the active tab we should deselect rather than re-apply. wdyt @olivermrbl?

Please drop a comment if you want to work on this 😄

Should we instead think of making the default available filters (

admin/src/components/templates/order-table/use-order-filters.ts

Line 355 in d79c68c

const availableTabs = useMemo(() => {

) removeable, by adding removable: true only after the filter gets selected?

I'm thinking this as when creating a new filter we make it removable and thus adds a close icon so the user knows that we can remove this filter, so in the same way the user will have a close icon for the default filters as well