Move integration tests into integration dir (#649)

* fix: moved integration tests into integration dir

* fix: test case error

* test: Add tests for ErrorBody with encoder

* chore: Update Go version in tests workflow

* chore: Remove ignore rule in codecov.yml

* chore: Update Go versions in test workflow

* chore: tests.yml: Improve integration tests workflow

* feat: ci: Add unit tests and coverage merging

* chore: update gocovmerge tool

* chore: fix version of tool

* chore: workflow: Update Go versions for pre-release tests

* test: Add SearchRequest validation tests

* tests: fix add get document by ids to integration dir

* fix: rename locates to locales

* fix: integration tests

* fix: revert locates changes

* fix: reverted latest version

* chore: fix reverted struct error

* ci: remove need linter

* chore: fix conflicts

* chore: revert break change

* chore: remove VectorStore field from types

* fix: remove vector store

Author: ja7ad

.github/workflows/tests.yml

@@ -61,8 +61,16 @@ jobs:
           fi
       - name: Meilisearch setup (latest version) with Docker
         run: docker run -d -p 7700:7700 getmeili/meilisearch:latest meilisearch --master-key=masterKey --no-analytics
+      - name: Run unit tests
+        run: |
+          go test --race -v -gcflags=-l -coverprofile=unit_coverage.txt -covermode=atomic $(go list ./... | grep -v /integration)
       - name: Run integration tests
-        run: go test -v -race -coverprofile=coverage.txt -covermode=atomic ./...
+        run: |
+          go test --race -v -gcflags=-l -coverprofile=integration_coverage.txt -covermode=atomic -coverpkg=./... ./integration
+      - name: Merge coverage reports
+        run: |
+          go install github.com/ja7ad/gocovmerge/cmd/[email protected]
+          gocovmerge unit_coverage.txt integration_coverage.txt > coverage.txt
       - name: Upload coverage report
         uses: codecov/codecov-action@v5
         env:

codecov.yml

@@ -1,5 +1,3 @@
-ignore:
-  - "types_easyjson.go"
 coverage:
   range: 60..80
   round: down

encoding_test.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"io"
@@ -29,6 +30,24 @@ func (e *errorReader) Read(p []byte) (int, error) {
 	return 0, errors.New("read error")
 }
 
+type mockEncoder struct{}
+
+func (m *mockEncoder) Encode(r io.Reader) (io.ReadCloser, error) {
+	return nil, nil
+}
+
+func (m *mockEncoder) Decode(data []byte, v interface{}) error {
+	msg, ok := v.(*meilisearchApiError)
+	if !ok {
+		return fmt.Errorf("wrong type")
+	}
+	msg.Message = "mocked message"
+	msg.Code = "mocked code"
+	msg.Type = "mocked type"
+	msg.Link = "mocked link"
+	return nil
+}
+
 func Test_Encode_ErrorOnNewWriter(t *testing.T) {
 	g := &gzipEncoder{
 		gzWriterPool: &sync.Pool{

error_test.go

@@ -2,6 +2,7 @@ package meilisearch
 
 import (
 	"fmt"
+	"io"
 	"net/http"
 	"testing"
 
@@ -47,3 +48,36 @@ func TestError_VersionErrorHintMessage(t *testing.T) {
 		})
 	}
 }
+
+type failEncoder struct{}
+
+func (f *failEncoder) Encode(r io.Reader) (io.ReadCloser, error) {
+	return nil, nil
+}
+func (f *failEncoder) Decode(_ []byte, v interface{}) error {
+	return fmt.Errorf("decode failed")
+}
+
+func TestError_ErrorBody_WithEncoder(t *testing.T) {
+
+	err := &Error{
+		encoder: &mockEncoder{},
+	}
+	body := []byte(`{"message":"should not be used"}`)
+	err.ErrorBody(body)
+	require.Equal(t, "mocked message", err.MeilisearchApiError.Message)
+	require.Equal(t, "mocked code", err.MeilisearchApiError.Code)
+	require.Equal(t, "mocked type", err.MeilisearchApiError.Type)
+	require.Equal(t, "mocked link", err.MeilisearchApiError.Link)
+
+	err2 := &Error{
+		encoder: &failEncoder{},
+	}
+	body2 := []byte(`{"message":"should not be used"}`)
+	err2.ErrorBody(body2)
+	// Should not set MeilisearchApiError fields
+	require.Empty(t, err2.MeilisearchApiError.Message)
+	require.Empty(t, err2.MeilisearchApiError.Code)
+	require.Empty(t, err2.MeilisearchApiError.Type)
+	require.Empty(t, err2.MeilisearchApiError.Link)
+}

features_test.go renamed to integration/features_test.go

@@ -1,21 +1,22 @@
-package meilisearch
+package integration
 
 import (
 	"crypto/tls"
 	"testing"
 
+	"github.com/meilisearch/meilisearch-go"
 	"github.com/stretchr/testify/require"
 )
 
 func TestGet_ExperimentalFeatures(t *testing.T) {
 	sv := setup(t, "")
-	customSv := setup(t, "", WithCustomClientWithTLS(&tls.Config{
+	customSv := setup(t, "", meilisearch.WithCustomClientWithTLS(&tls.Config{
 		InsecureSkipVerify: true,
 	}))
 
 	tests := []struct {
 		name   string
-		client ServiceManager
+		client meilisearch.ServiceManager
 	}{
 		{
 			name:   "TestGetStats",
@@ -39,13 +40,13 @@ func TestGet_ExperimentalFeatures(t *testing.T) {
 
 func TestUpdate_ExperimentalFeatures(t *testing.T) {
 	sv := setup(t, "")
-	customSv := setup(t, "", WithCustomClientWithTLS(&tls.Config{
+	customSv := setup(t, "", meilisearch.WithCustomClientWithTLS(&tls.Config{
 		InsecureSkipVerify: true,
 	}))
 
 	tests := []struct {
 		name   string
-		client ServiceManager
+		client meilisearch.ServiceManager
 	}{
 		{
 			name:   "TestUpdateStats",
@@ -68,6 +69,7 @@ func TestUpdate_ExperimentalFeatures(t *testing.T) {
 			ef.SetCompositeEmbedders(true)
 			gotResp, err := ef.Update()
 			require.NoError(t, err)
+
 			require.Equal(t, true, gotResp.LogsRoute, "ExperimentalFeatures.Update() should return logsRoute as true")
 			require.Equal(t, true, gotResp.Metrics, "ExperimentalFeatures.Update() should return metrics as true")
 			require.Equal(t, true, gotResp.EditDocumentsByFunction, "ExperimentalFeatures.Update() should return editDocumentsByFunction as true")