Skip to content
This repository was archived by the owner on May 13, 2021. It is now read-only.

Commit d0f6331

Browse files
authored
Merge pull request #2 from meilisearch/update-owner
update owner
2 parents 1632cbd + a9ecdc8 commit d0f6331

File tree

8 files changed

+47
-42
lines changed

8 files changed

+47
-42
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ Here is the [MeiliSearch documentation](https://docs.meilisearch.com/) 📖
2020
### Composer
2121

2222
```bash
23-
$ composer require shokme/laravel-scout-meilisearch
23+
$ composer require meilisearch/meilisearch-laravel-scout
2424
```
2525

2626
### Export configuration
2727

2828
```bash
2929
$ php artisan vendor:publish --provider="Laravel\Scout\ScoutServiceProvider"
30-
$ php artisan vendor:publish --provider="Shokme\Meilisearch\MeilisearchServiceProvider" --tag="config"
30+
$ php artisan vendor:publish --provider="Meilisearch\Scout\MeilisearchServiceProvider" --tag="config"
3131
```
3232

3333
### Update .env
@@ -129,7 +129,7 @@ or you can use the artisan command to delete all documents from an index:
129129
$ php artisan scout:flush "App\Book"
130130
```
131131

132-
### Delete an index
132+
#### Delete an index
133133
```bash
134134
$ php artisan scout:index -d books
135135
```

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "shokme/laravel-scout-meilisearch",
2+
"name": "meilisearch/meilisearch-laravel-scout",
33
"description": "Laravel Scout custom engine for MeiliSearch",
44
"keywords": ["meilisearch", "laravel", "scout", "search"],
55
"type": "library",
@@ -22,18 +22,18 @@
2222
},
2323
"autoload": {
2424
"psr-4": {
25-
"Shokme\\Meilisearch\\": "src"
25+
"Meilisearch\\Scout\\": "src"
2626
}
2727
},
2828
"autoload-dev": {
2929
"psr-4": {
30-
"Shokme\\Meilisearch\\Tests\\": "tests"
30+
"Meilisearch\\Scout\\Tests\\": "tests"
3131
}
3232
},
3333
"extra": {
3434
"laravel": {
3535
"providers": [
36-
"Shokme\\Meilisearch\\MeilisearchServiceProvider"
36+
"Meilisearch\\Scout\\MeilisearchServiceProvider"
3737
]
3838
}
3939
},

src/Console/IndexMeilisearch.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<?php
22

3-
namespace Shokme\Meilisearch\Console;
3+
namespace Meilisearch\Scout\Console;
44

55
use Illuminate\Console\Command;
66
use MeiliSearch\Client;
77
use MeiliSearch\Exceptions\HTTPRequestException;
8-
use Shokme\Meilisearch\Engines\MeilisearchEngine;
8+
use Meilisearch\Engines\MeilisearchEngine;
99

1010
class IndexMeilisearch extends Command
1111
{

src/Engines/MeilisearchEngine.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
namespace Shokme\Meilisearch\Engines;
3+
namespace Meilisearch\Scout\Engines;
44

55
use Laravel\Scout\Engines\Engine;
66
use MeiliSearch\Client as Meilisearch;

src/MeilisearchServiceProvider.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<?php
22

3-
namespace Shokme\Meilisearch;
3+
namespace Meilisearch\Scout;
44

55
use Illuminate\Support\ServiceProvider;
66
use Laravel\Scout\EngineManager;
77
use MeiliSearch\Client;
8-
use Shokme\Meilisearch\Console\IndexMeilisearch;
9-
use Shokme\Meilisearch\Console\RequestMeilisearch;
10-
use Shokme\Meilisearch\Engines\MeilisearchEngine;
8+
use Meilisearch\Scout\Console\IndexMeilisearch;
9+
use Meilisearch\Scout\Engines\MeilisearchEngine;
1110

1211
class MeilisearchServiceProvider extends ServiceProvider
1312
{

tests/Fixtures/SearchableModel.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
namespace Shokme\Meilisearch\Tests\Fixtures;
3+
namespace Meilisearch\Scout\Tests\Fixtures;
44

55
use Illuminate\Database\Eloquent\Model;
66
use Laravel\Scout\Searchable;
@@ -12,7 +12,7 @@ class SearchableModel extends Model
1212
/**
1313
* The attributes that are mass assignable.
1414
*/
15-
protected array $fillable = ['id'];
15+
protected $fillable = ['id'];
1616

1717
public function searchableAs()
1818
{

tests/MeilisearchEngineTest.php

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<?php
22

3-
namespace Shokme\Meilisearch\Tests;
3+
namespace Meilisearch\Scout\Tests;
44

55
use MeiliSearch\Client;
66
use Illuminate\Database\Eloquent\Collection;
77
use Laravel\Scout\Builder;
8-
use Shokme\Meilisearch\Engines\MeilisearchEngine;
9-
use Shokme\Meilisearch\Tests\Fixtures\SearchableModel;
8+
use Meilisearch\Scout\Engines\MeilisearchEngine;
9+
use Meilisearch\Scout\Tests\Fixtures\SearchableModel;
1010
use Mockery as m;
1111
use stdClass;
1212

@@ -22,9 +22,11 @@ public function update_adds_objects_to_index()
2222
{
2323
$client = m::mock(Client::class);
2424
$client->shouldReceive('getIndex')->with('table')->andReturn($index = m::mock(stdClass::class));
25-
$index->shouldReceive('saveObjects')->with([[
26-
'id' => 1
27-
]]);
25+
$index->shouldReceive('addDocuments')->with([
26+
[
27+
'id' => 1
28+
]
29+
]);
2830

2931
$engine = new MeilisearchEngine($client);
3032
$engine->update(Collection::make([new SearchableModel]));
@@ -47,44 +49,46 @@ public function search_sends_correct_parameters_to_meilisearch()
4749
$client = m::mock(Client::class);
4850
$client->shouldReceive('getIndex')->with('table')->andReturn($index = m::mock(stdClass::class));
4951
$index->shouldReceive('search')->with('mustang', [
50-
'filters' => ['foo=1'],
52+
'filters' => 'foo=1',
5153
]);
5254

5355
$engine = new MeilisearchEngine($client);
54-
$builder = new Builder(new SearchableModel, 'mustang');
55-
$builder->where('filters', ['foo=1']);
56+
$builder = new Builder(new SearchableModel, 'mustang', function ($meilisearch, $query, $options) {
57+
$options['filters'] = 'foo=1';
58+
59+
return $meilisearch->search($query, $options);
60+
});
5661
$engine->search($builder);
5762
}
5863

5964
/** @test */
6065
public function map_correctly_maps_results_to_models()
6166
{
62-
$this->markTestSkipped('TODO: try to prevent need of sql');
63-
6467
$client = m::mock(Client::class);
6568
$engine = new MeilisearchEngine($client);
6669

6770
$model = m::mock(stdClass::class);
68-
$model->shouldReceive('getScoutModelsByIds')->andReturn(Collection::make([new SearchableModel(['id' => 1])]));
69-
71+
$model->shouldReceive(['getKeyName' => 'id']);
72+
$model->shouldReceive('getScoutModelsByIds')->andReturn($models = Collection::make([new SearchableModel(['id' => 1])]));
7073
$builder = m::mock(Builder::class);
7174

72-
$results = $engine->map($builder, ['nbHits' => 1, 'hits' => [
73-
['id' => 1],
74-
]], new SearchableModel());
75+
$results = $engine->map($builder, [
76+
'nbHits' => 1, 'hits' => [
77+
['id' => 1],
78+
]
79+
], $model);
7580

7681
$this->assertEquals(1, count($results));
7782
}
7883

7984
/** @test */
8085
public function map_method_respects_order()
8186
{
82-
$this->markTestSkipped('TODO: try to prevent need of sql');
83-
8487
$client = m::mock(Client::class);
8588
$engine = new MeilisearchEngine($client);
8689

8790
$model = m::mock(stdClass::class);
91+
$model->shouldReceive(['getKeyName' => 'id']);
8892
$model->shouldReceive('getScoutModelsByIds')->andReturn($models = Collection::make([
8993
new SearchableModel(['id' => 1]),
9094
new SearchableModel(['id' => 2]),
@@ -94,12 +98,14 @@ public function map_method_respects_order()
9498

9599
$builder = m::mock(Builder::class);
96100

97-
$results = $engine->map($builder, ['nbHits' => 4, 'hits' => [
98-
['id' => 1],
99-
['id' => 2],
100-
['id' => 4],
101-
['id' => 3],
102-
]], new SearchableModel());
101+
$results = $engine->map($builder, [
102+
'nbHits' => 4, 'hits' => [
103+
['id' => 1],
104+
['id' => 2],
105+
['id' => 4],
106+
['id' => 3],
107+
]
108+
], $model);
103109

104110
$this->assertEquals(4, count($results));
105111
$this->assertEquals([

tests/TestCase.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?php
22

3-
namespace Shokme\Meilisearch\Tests;
3+
namespace Meilisearch\Scout\Tests;
44

5-
use Shokme\Meilisearch\MeilisearchServiceProvider;
5+
use Meilisearch\Scout\MeilisearchServiceProvider;
66

77
class TestCase extends \Orchestra\Testbench\TestCase
88
{

0 commit comments

Comments
 (0)