From 4b8d94d16c6457101d7c98c99ed961aec74e2b3d Mon Sep 17 00:00:00 2001 From: Strift Date: Fri, 12 Sep 2025 16:06:42 +0800 Subject: [PATCH 1/4] Update CI workflows --- .github/workflows/release-drafter.yml | 1 + .github/workflows/tests.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml index 20f2d83f..49fbecc2 100644 --- a/.github/workflows/release-drafter.yml +++ b/.github/workflows/release-drafter.yml @@ -4,6 +4,7 @@ on: push: branches: - main + - v1.x jobs: update_release_draft: diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f095115f..562c45a0 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -9,6 +9,7 @@ on: - staging - main - feature/** + - v1.x jobs: yaml-lint: From 8f7a3e134257f9b813caa91bae97fca49584dce8 Mon Sep 17 00:00:00 2001 From: Strift Date: Fri, 12 Sep 2025 16:07:02 +0800 Subject: [PATCH 2/4] Update contributors --- composer.json | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 8e382a03..52c1875c 100644 --- a/composer.json +++ b/composer.json @@ -13,8 +13,20 @@ "license": "MIT", "authors": [ { - "name": "Clementine", + "name": "Clémentine Urquizar", "email": "clementine@meilisearch.com" + }, + { + "name": "Bruno Casali", + "email": "bruno@meilisearch.com" + }, + { + "name": "Laurent Cazanove", + "email": "lau.cazanove@gmail.com" + }, + { + "name": "Tomas Norkūnas", + "email": "norkunas.tom@gmail.com" } ], "minimum-stability": "stable", @@ -58,7 +70,9 @@ "./vendor/bin/php-cs-fixer fix --verbose --config=.php-cs-fixer.dist.php --using-cache=no --diff" ], "phpstan": "./vendor/bin/phpstan", - "test": ["sh scripts/tests.sh"] + "test": [ + "sh scripts/tests.sh" + ] }, "config": { "allow-plugins": { From 5cd3792326d8234997c3ad0cf762cb02bc4fe7c2 Mon Sep 17 00:00:00 2001 From: Strift Date: Fri, 12 Sep 2025 17:04:37 +0800 Subject: [PATCH 3/4] Update empty string comparison --- src/Exceptions/ApiException.php | 2 +- src/Exceptions/InvalidResponseBodyException.php | 2 +- src/Exceptions/TimeOutException.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Exceptions/ApiException.php b/src/Exceptions/ApiException.php index 2e0f21c7..ff88dfe6 100644 --- a/src/Exceptions/ApiException.php +++ b/src/Exceptions/ApiException.php @@ -33,7 +33,7 @@ public function __toString() { $base = 'Meilisearch ApiException: Http Status: '.$this->httpStatus; - if (!\is_null($this->message)) { + if ($this->message !== '') { $base .= ' - Message: '.$this->message; } diff --git a/src/Exceptions/InvalidResponseBodyException.php b/src/Exceptions/InvalidResponseBodyException.php index 5eff72fd..ec0a2306 100644 --- a/src/Exceptions/InvalidResponseBodyException.php +++ b/src/Exceptions/InvalidResponseBodyException.php @@ -25,7 +25,7 @@ public function __toString() { $base = 'Meilisearch InvalidResponseBodyException: Http Status: '.$this->httpStatus; - if ($this->message) { + if ($this->message !== '') { $base .= ' - Message: '.$this->message; } diff --git a/src/Exceptions/TimeOutException.php b/src/Exceptions/TimeOutException.php index 7a4cee15..c62f66c6 100644 --- a/src/Exceptions/TimeOutException.php +++ b/src/Exceptions/TimeOutException.php @@ -20,7 +20,7 @@ public function __construct(?string $message = null, ?int $code = null, ?\Throwa public function __toString() { $base = 'Meilisearch TimeOutException: Code: '.$this->code; - if ($this->message) { + if ($this->message !== '') { return $base.' - Message: '.$this->message; } else { return $base; From d91882a68143917e85bec924f1ede833849c4111 Mon Sep 17 00:00:00 2001 From: Strift Date: Fri, 12 Sep 2025 17:11:36 +0800 Subject: [PATCH 4/4] lint --- src/Exceptions/ApiException.php | 2 +- src/Exceptions/InvalidResponseBodyException.php | 2 +- src/Exceptions/TimeOutException.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Exceptions/ApiException.php b/src/Exceptions/ApiException.php index ff88dfe6..f7ebc1e9 100644 --- a/src/Exceptions/ApiException.php +++ b/src/Exceptions/ApiException.php @@ -33,7 +33,7 @@ public function __toString() { $base = 'Meilisearch ApiException: Http Status: '.$this->httpStatus; - if ($this->message !== '') { + if ('' !== $this->message) { $base .= ' - Message: '.$this->message; } diff --git a/src/Exceptions/InvalidResponseBodyException.php b/src/Exceptions/InvalidResponseBodyException.php index ec0a2306..5245df44 100644 --- a/src/Exceptions/InvalidResponseBodyException.php +++ b/src/Exceptions/InvalidResponseBodyException.php @@ -25,7 +25,7 @@ public function __toString() { $base = 'Meilisearch InvalidResponseBodyException: Http Status: '.$this->httpStatus; - if ($this->message !== '') { + if ('' !== $this->message) { $base .= ' - Message: '.$this->message; } diff --git a/src/Exceptions/TimeOutException.php b/src/Exceptions/TimeOutException.php index c62f66c6..cf2c3a6e 100644 --- a/src/Exceptions/TimeOutException.php +++ b/src/Exceptions/TimeOutException.php @@ -20,7 +20,7 @@ public function __construct(?string $message = null, ?int $code = null, ?\Throwa public function __toString() { $base = 'Meilisearch TimeOutException: Code: '.$this->code; - if ($this->message !== '') { + if ('' !== $this->message) { return $base.' - Message: '.$this->message; } else { return $base;