make_pair seems broken?

[mcourteaux]

Consider:

std::string a = "sd";
unsigned int b = 5;

auto pair = tinystl::make_pair(a, b);

Now, the pair variable seems to be of type tinystl::pair<const std::string, unsigned int>.
As far as I can tell, the const in front of the string is very inconvenient (and I believe wrong, according to the spec).

The std implementation has some special stuff going on with unwrap_ref_decay_t, which I believe takes care of dropping the const: https://en.cppreference.com/w/cpp/utility/pair/make_pair

[mendsley]

I think I agree. I would expect pair to have the type pair<string, unsigned int> and not pair<const string, unsigned int>.

What compiler/version are you using?

[mcourteaux]

Was working with the zig C++ compiler, which is basically clang version 19.1.0 (https://github.com/ziglang/zig-bootstrap 3f9c0f8f8b6e09280507d5445f6c971ec7776f10)